Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2841)

Unified Diff: chrome/browser/profile.h

Issue 332006: Remove the restriction that ChromeURLRequestContextGetter needs to be release... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to latest changes Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/external_tab_container.cc ('k') | chrome/browser/profile.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profile.h
===================================================================
--- chrome/browser/profile.h (revision 32405)
+++ chrome/browser/profile.h (working copy)
@@ -116,9 +116,6 @@
// from any thread. This CAN return NULL if a first request context has not
// yet been created. If necessary, listen on the UI thread for
// NOTIFY_DEFAULT_REQUEST_CONTEXT_AVAILABLE.
- //
- // The returned object is ref'd by the profile. Callers who AddRef() it (to
- // keep it alive longer than the profile) must Release() it on the I/O thread.
static URLRequestContextGetter* GetDefaultRequestContext();
// Returns a unique Id that can be used to identify this profile at runtime.
@@ -278,9 +275,6 @@
// Returns the request context information associated with this profile. Call
// this only on the UI thread, since it can send notifications that should
// happen on the UI thread.
- //
- // The returned object is ref'd by the profile. Callers who AddRef() it (to
- // keep it alive longer than the profile) must Release() it on the I/O thread.
virtual URLRequestContextGetter* GetRequestContext() = 0;
// Returns the request context for media resources asociated with this
@@ -548,11 +542,11 @@
scoped_ptr<ProfileSyncService> sync_service_;
- ChromeURLRequestContextGetter* request_context_;
+ scoped_refptr<ChromeURLRequestContextGetter> request_context_;
- ChromeURLRequestContextGetter* media_request_context_;
+ scoped_refptr<ChromeURLRequestContextGetter> media_request_context_;
- ChromeURLRequestContextGetter* extensions_request_context_;
+ scoped_refptr<ChromeURLRequestContextGetter> extensions_request_context_;
scoped_ptr<SSLConfigServiceManager> ssl_config_service_manager_;
« no previous file with comments | « chrome/browser/external_tab_container.cc ('k') | chrome/browser/profile.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698