Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 329017: Remove deprecated CommandLine(std::wstring) ctor. (Closed)

Created:
11 years, 2 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove deprecated CommandLine(std::wstring) ctor. Add a ctor for creating a CommandLine for carrying arguments; convert all the users to either that or the FilePath version. BUG=24672 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -83 lines) Patch
M base/command_line.h View 2 chunks +9 lines, -3 lines 0 comments Download
M base/command_line.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M base/command_line_unittest.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M base/process_util_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/app/chrome_main_uitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_init_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extensions_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/images_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context_unittest.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/user_data_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/render_view_test.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/tools/crash_service/crash_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome_frame/chrome_launcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome_frame/test/net/process_singleton_subclass.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/disk_cache/stress_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/crash_cache/crash_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/dump_cache.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
11 years, 2 months ago (2009-10-24 03:18:05 UTC) #1
Lei Zhang
LGTM Does it pass the try server?
11 years, 1 month ago (2009-10-26 18:46:34 UTC) #2
Evan Martin
11 years, 1 month ago (2009-10-26 18:57:30 UTC) #3 
On 2009/10/26 18:46:34, Lei Zhang wrote:
> LGTM
> 
> Does it pass the try server?

Yes, it took a million iterations through the try server to get it working.  :)

Powered by Google App Engine
This is Rietveld 408576698