chrome/installer/util/shell_util.cc - Issue 329017: Remove deprecated CommandLine(std::wstring) ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/shell_util.cc

Issue 329017: Remove deprecated CommandLine(std::wstring) ctor. (Closed)

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/shell_util.cc

diff --git a/chrome/installer/util/shell_util.cc b/chrome/installer/util/shell_util.cc

index 8e00ba21c91e77fda94b09472e58ea4ab8d08aa7..6982fa7a8461e30e89f34b26f294142797c786a0 100644

--- a/chrome/installer/util/shell_util.cc

+++ b/chrome/installer/util/shell_util.cc

@@ -301,8 +301,7 @@ bool ElevateAndRegisterChrome(const std::wstring& chrome_exe,

HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE;

RegKey key(reg_root, dist->GetUninstallRegPath().c_str());

key.ReadValue(installer_util::kUninstallStringField, &exe_path);

- CommandLine command_line(L"");

- command_line.ParseFromString(exe_path);

+ CommandLine command_line = CommandLine::FromString(exe_path);

exe_path = command_line.program();

}

if (file_util::PathExists(FilePath::FromWStringHack(exe_path))) {