Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: base/process_util_unittest.cc

Issue 329017: Remove deprecated CommandLine(std::wstring) ctor. (Closed)
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/command_line_unittest.cc ('k') | chrome/app/chrome_main_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util_unittest.cc
diff --git a/base/process_util_unittest.cc b/base/process_util_unittest.cc
index 0dfcd2b76cf5f6a0ce4764ad089de44d2bb1b4fe..eff8fae167fb10c4ea9d5e93df01790e55c4bb57 100644
--- a/base/process_util_unittest.cc
+++ b/base/process_util_unittest.cc
@@ -151,7 +151,7 @@ TEST_F(ProcessUtilTest, GetAppOutput) {
.Append(FILE_PATH_LITERAL("python_24"))
.Append(FILE_PATH_LITERAL("python.exe"));
- CommandLine cmd_line(python_runtime.value());
+ CommandLine cmd_line(python_runtime);
cmd_line.AppendLooseValue(L"-c");
cmd_line.AppendLooseValue(L"\"import sys; sys.stdout.write('" +
ASCIIToWide(message) + L"');\"");
@@ -160,7 +160,7 @@ TEST_F(ProcessUtilTest, GetAppOutput) {
EXPECT_EQ(message, output);
// Let's make sure stderr is ignored.
- CommandLine other_cmd_line(python_runtime.value());
+ CommandLine other_cmd_line(python_runtime);
other_cmd_line.AppendLooseValue(L"-c");
other_cmd_line.AppendLooseValue(
L"\"import sys; sys.stderr.write('Hello!');\"");
@@ -260,10 +260,10 @@ TEST_F(ProcessUtilTest, FDRemapping) {
TEST_F(ProcessUtilTest, GetAppOutput) {
std::string output;
- EXPECT_TRUE(GetAppOutput(CommandLine(L"true"), &output));
+ EXPECT_TRUE(GetAppOutput(CommandLine(FilePath("true")), &output));
EXPECT_STREQ("", output.c_str());
- EXPECT_FALSE(GetAppOutput(CommandLine(L"false"), &output));
+ EXPECT_FALSE(GetAppOutput(CommandLine(FilePath("false")), &output));
std::vector<std::string> argv;
argv.push_back("/bin/echo");
« no previous file with comments | « base/command_line_unittest.cc ('k') | chrome/app/chrome_main_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698