Issue 3262001: Check result of JSObject::NormalizeProperties() in JSObject::PreventExtension...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3262001: Check result of JSObject::NormalizeProperties() in JSObject::PreventExtension... (Closed)

Created:
10 years, 3 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
antonm

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Check result of JSObject::NormalizeElements() in JSObject::PreventExtensions(). Normalization requires allocation so Failure object can be returned. BUG=http://code.google.com/p/v8/issues/detail?id=851 TEST=test/mjsunit/regress/regress-851.js Committed: http://code.google.com/p/v8/source/detail?r=5364

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -1 line)			Patch
	M	src/objects.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-851.js	View		1 chunk	+32 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

10 years, 3 months ago (2010-08-27 13:00:28 UTC) #2

LGTM!

http://codereview.chromium.org/3262001/diff/1/3
File test/mjsunit/regress/regress-851.js (right):

http://codereview.chromium.org/3262001/diff/1/3#newcode1
test/mjsunit/regress/regress-851.js:1: // Copyright 2008 the V8 project authors.
All rights reserved.
nit: 2008 -> 2010

Expand Messages | Collapse Messages