src/objects.cc - Issue 3262001: Check result of JSObject::NormalizeProperties() in JSObject::PreventExtension...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 3262001: Check result of JSObject::NormalizeProperties() in JSObject::PreventExtension... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

===================================================================

--- src/objects.cc (revision 5363)

+++ src/objects.cc (working copy)

@@ -2683,7 +2683,8 @@

Object* JSObject::PreventExtensions() {

// If there are fast elements we normalize.

if (HasFastElements()) {

- NormalizeElements();

+ Object* ok = NormalizeElements();

+ if (ok->IsFailure()) return ok;

}

// Make sure that we never go back to fast case.

element_dictionary()->set_requires_slow_elements();

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-851.js » ('j') | test/mjsunit/regress/regress-851.js » ('J')