Issue 3250009: Fix linux and mac page info windows showing wrong status icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3250009: Fix linux and mac page info windows showing wrong status icons. (Closed)

Created:
10 years, 3 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Finnur, Jay Civelli

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Fix linux and mac page info windows showing wrong status icons. BUG=52916 TEST=load https://www.google.com, click on page info Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57936

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/page_info_window_mac.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/gtk/page_info_window_gtk.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mattm

http://codereview.chromium.org/3171031/show changed the meaning of PageInfoModel::SectionInfo.state, but only updated the views users. (Note: mac change ...

10 years, 3 months ago (2010-08-30 23:13:09 UTC) #1

LGTM

Expand Messages | Collapse Messages