Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: chrome/browser/cocoa/page_info_window_mac.mm

Issue 3250009: Fix linux and mac page info windows showing wrong status icons. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/gtk/page_info_window_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/page_info_window_mac.mm
diff --git a/chrome/browser/cocoa/page_info_window_mac.mm b/chrome/browser/cocoa/page_info_window_mac.mm
index a69fa494f0f76f29a8dbe259cf0aa0df89b97e07..306d1edb9700ff75a06e80fb3b5d7b77541d4d8f 100644
--- a/chrome/browser/cocoa/page_info_window_mac.mm
+++ b/chrome/browser/cocoa/page_info_window_mac.mm
@@ -221,7 +221,8 @@ void PageInfoWindowMac::LayoutSections() {
scoped_nsobject<NSImageView> image_view(
[[NSImageView alloc] initWithFrame:image_view_rect]);
[image_view setImageFrameStyle:NSImageFrameNone];
- [image_view setImage:(info.state) ? good_image_.get() : bad_image_.get()];
+ [image_view setImage:(info.state != PageInfoModel::SECTION_STATE_ERROR) ?
+ good_image_.get() : bad_image_.get()];
// Add the box to the list of new subviews.
[box addSubview:image_view.get()];
« no previous file with comments | « no previous file | chrome/browser/gtk/page_info_window_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698