chrome/browser/gtk/page_info_window_gtk.cc - Issue 3250009: Fix linux and mac page info windows showing wrong status icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/gtk/page_info_window_gtk.cc

Issue 3250009: Fix linux and mac page info windows showing wrong status icons. (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/gtk/page_info_window_gtk.cc

diff --git a/chrome/browser/gtk/page_info_window_gtk.cc b/chrome/browser/gtk/page_info_window_gtk.cc

index 87671ae360ff5a8e5bf75e9131e127e77d3dc4c1..ef89e77a76421630a7352860a27990c0ef148e9f 100644

--- a/chrome/browser/gtk/page_info_window_gtk.cc

+++ b/chrome/browser/gtk/page_info_window_gtk.cc

@@ -149,7 +149,8 @@ GtkWidget* PageInfoWindowGtk::CreateSection(

GtkWidget* section_box = gtk_hbox_new(FALSE, 0);

ResourceBundle& rb = ResourceBundle::GetSharedInstance();

- GtkWidget* image = gtk_image_new_from_pixbuf(section.state ?

+ GtkWidget* image = gtk_image_new_from_pixbuf(

+ section.state != PageInfoModel::SECTION_STATE_ERROR ?

rb.GetPixbufNamed(IDR_PAGEINFO_GOOD) :

rb.GetPixbufNamed(IDR_PAGEINFO_BAD));

gtk_box_pack_start(GTK_BOX(section_box), image, FALSE, FALSE,

« no previous file with comments | « chrome/browser/cocoa/page_info_window_mac.mm ('k') | no next file » | no next file with comments »