Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 3245012: Show Page Info InfoBubble on the right side for RTL languages and make sure W... (Closed)

Created:
10 years, 3 months ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
mattm
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Show Page Info InfoBubble on the right side for RTL languages and make sure Warning is treated as error in old dialog (which is how it was before). BUG=http://crbug.com/52916 TEST=Open SSL Infobubble on RTL languages, make sure it points to the right location. Then open a gmail containing an external image (not attached, but embedded) and make sure the old SSL dialog (not the infobubble) shows an error for mixed content, not the green icon. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58150

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/cocoa/page_info_window_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/page_info_window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/page_info_bubble_view.cc View 1 chunk +5 lines, -1 line 1 comment Download
M chrome/browser/views/page_info_window_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Finnur
So, to answer your question, Matt: no, the state should not be set to OK ...
10 years, 3 months ago (2010-08-31 10:28:41 UTC) #1
mattm
On 2010/08/31 10:28:41, Finnur wrote: > So, to answer your question, Matt: no, the state ...
10 years, 3 months ago (2010-08-31 18:28:07 UTC) #2
mattm
http://codereview.chromium.org/3245012/diff/1/4 File chrome/browser/views/page_info_bubble_view.cc (right): http://codereview.chromium.org/3245012/diff/1/4#newcode329 chrome/browser/views/page_info_bubble_view.cc:329: BubbleBorder::TOP_LEFT, Oh yeah, I think this should also be ...
10 years, 3 months ago (2010-08-31 19:01:36 UTC) #3
Finnur
10 years, 3 months ago (2010-09-01 08:54:59 UTC) #4
Good suggestion, but the bubble takes care of that internally.

Powered by Google App Engine
This is Rietveld 408576698