Show Page Info InfoBubble on the right side for RTL languages and make sure W...

Show Page Info InfoBubble on the right side for RTL languages and make sure Warning is treated as error in old dialog (which is how it was before).

BUG=http://crbug.com/52916
TEST=Open SSL Infobubble on RTL languages, make sure it points to the right location. Then open a gmail containing an external image (not attached, but embedded) and make sure the old SSL dialog (not the infobubble) shows an error for mixed content, not the green icon.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58150

[Finnur, 2010-08-31 10:28:41]

So, to answer your question, Matt: no, the state should not be set to OK on
warning for the old implementation. It made sense in the context of another
changelist, but no longer does. I have changed it; thanks for bringing it up.

[mattm, 2010-08-31 18:28:07]

On 2010/08/31 10:28:41, Finnur wrote:
> So, to answer your question, Matt: no, the state should not be set to OK on
> warning for the old implementation. It made sense in the context of another
> changelist, but no longer does. I have changed it; thanks for bringing it up.

LGTM

[mattm, 2010-08-31 19:01:36]

http://codereview.chromium.org/3245012/diff/1/4
File chrome/browser/views/page_info_bubble_view.cc (right):

http://codereview.chromium.org/3245012/diff/1/4#newcode329
chrome/browser/views/page_info_bubble_view.cc:329: BubbleBorder::TOP_LEFT,
Oh yeah, I think this should also be TOP_RIGHT, in the RTL case.

[Finnur, 2010-09-01 08:54:59]

Good suggestion, but the bubble takes care of that internally.