Show Page Info InfoBubble on the right side for RTL languages and make sure W...

chrome/browser/views/page_info_bubble_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/page_info_bubble_view.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_list.h"
@@ skipping 292 matching lines @@
 namespace browser {
 
 void ShowPageInfoBubble(gfx::NativeWindow parent,
                         Profile* profile,
                         const GURL& url,
                         const NavigationEntry::SSLStatus& ssl,
                         bool show_history) {
   // Find where to point the bubble at.
   BrowserView* browser_view =
       BrowserView::GetBrowserViewForNativeWindow(parent);
-  gfx::Rect bounds = browser_view->toolbar()->location_bar()->bounds();
   gfx::Point point;
+  if (base::i18n::IsRTL()) {
+    int width = browser_view->toolbar()->location_bar()->width();
+    point = gfx::Point(width - kIconOffset, 0);
+  }
   views::View::ConvertPointToScreen(browser_view->toolbar()->location_bar(),
                                     &point);
+  gfx::Rect bounds = browser_view->toolbar()->location_bar()->bounds();
   bounds.set_origin(point);
   bounds.set_width(kIconOffset);
 
   // Show the bubble.
   PageInfoBubbleView* page_info_bubble =
       new PageInfoBubbleView(parent, profile, url, ssl, show_history);
   InfoBubble* info_bubble =
       InfoBubble::Show(browser_view->GetWidget(), bounds,
                        BubbleBorder::TOP_LEFT,

[mattm, 2010/08/31 19:01:36]

Oh yeah, I think this should also be TOP_RIGHT, in the RTL case.

                        page_info_bubble, page_info_bubble);
   page_info_bubble->set_info_bubble(info_bubble);
 }
 
 }