Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4990)

Unified Diff: chrome/browser/views/page_info_bubble_view.cc

Issue 3245012: Show Page Info InfoBubble on the right side for RTL languages and make sure W... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/page_info_window_gtk.cc ('k') | chrome/browser/views/page_info_window_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/page_info_bubble_view.cc
===================================================================
--- chrome/browser/views/page_info_bubble_view.cc (revision 57972)
+++ chrome/browser/views/page_info_bubble_view.cc (working copy)
@@ -310,10 +310,14 @@
// Find where to point the bubble at.
BrowserView* browser_view =
BrowserView::GetBrowserViewForNativeWindow(parent);
- gfx::Rect bounds = browser_view->toolbar()->location_bar()->bounds();
gfx::Point point;
+ if (base::i18n::IsRTL()) {
+ int width = browser_view->toolbar()->location_bar()->width();
+ point = gfx::Point(width - kIconOffset, 0);
+ }
views::View::ConvertPointToScreen(browser_view->toolbar()->location_bar(),
&point);
+ gfx::Rect bounds = browser_view->toolbar()->location_bar()->bounds();
bounds.set_origin(point);
bounds.set_width(kIconOffset);
« no previous file with comments | « chrome/browser/gtk/page_info_window_gtk.cc ('k') | chrome/browser/views/page_info_window_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698