Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 3244001: Use text-overflow: ellipsis for long words in sync set-up UI. ... (Closed)

Created:
10 years, 4 months ago by Mark Larson
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana
Visibility:
Public.

Description

Fix truncation in in the sync setup dialog on the 472 branch. This is an extension of Jungshik's patch: http://codereview.chromium.org/3142042/show BUG=53494 TEST=1. Open sync setup UI in French, Italian, Brazilliant Portugest (pt-BR) and see if the translation for 'autofill' is ellipsized rather than truncated. 2. Open sync setup UI and 'Choose what to sync:' is on the same line as the corresponding radio button. 3. If any strings are truncated, ellipsis-ized, resize the dialog wider to make them readable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57639

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/browser/sync/resources/choose_datatypes.html View 3 chunks +13 lines, -2 lines 3 comments Download

Messages

Total messages: 2 (0 generated)
Mark Larson
Jungshik's changes: ------------------------------------- Use text-overflow: ellipsis for long words in sync set-up UI. In r57340, ...
10 years, 4 months ago (2010-08-27 05:38:30 UTC) #1
arv (Not doing code reviews)
10 years, 3 months ago (2010-09-01 01:04:02 UTC) #2
http://codereview.chromium.org/3244001/diff/1/2
File chrome/browser/sync/resources/choose_datatypes.html (right):

http://codereview.chromium.org/3244001/diff/1/2#newcode34
chrome/browser/sync/resources/choose_datatypes.html:34: width: 90%;
This seems like the wrong solution. Maybe you want to use margins instead?

http://codereview.chromium.org/3244001/diff/1/2#newcode54
chrome/browser/sync/resources/choose_datatypes.html:54: width: 92%;
In general percentage widths are not that useful unless you actually mean 92%
(which I doubt). When you have to use these arbitrary percentage values it is
usually better to use width: 100%/auto and margins/paddings.

http://codereview.chromium.org/3244001/diff/1/2#newcode300
chrome/browser/sync/resources/choose_datatypes.html:300: <div
class="sync-item-show" id="autofillItem">
I think there is room for simplification here.

You can skip the div and use the following markup:

<label><input ...><span i18n-content ...></span></label>

Since the label is using display inline-block you need to ensure that there is
no whitespace between the labels.

Then set the width of the label to 50% and two labels will fit nicely in the
container and the ellipsis will work as expected.

Powered by Google App Engine
This is Rietveld 408576698