Chromium Code Reviews Chromium Code Reviews
Issue 3244001:
Use text-overflow: ellipsis for long words in sync set-up UI. ... (Closed)
Base URL: svn://svn.chromium.org/chrome/branches/472/src/| OLD | NEW |
|---|---|
| 1 <html i18n-values="dir:textdirection;"> | 1 <html i18n-values="dir:textdirection;"> |
| 2 <head> | 2 <head> |
| 3 <title></title> | 3 <title></title> |
| 4 <style type="text/css"> | 4 <style type="text/css"> |
| 5 body { | 5 body { |
| 6 line-height: 1.5em; | 6 line-height: 1.5em; |
| 7 background: #FFFFFF; | 7 background: #FFFFFF; |
| 8 margin: 10px 15px; | 8 margin: 10px 15px; |
| 9 font-size: 11pt; | 9 font-size: 11pt; |
| 10 } | 10 } |
| (...skipping 13 matching lines...) Expand all Loading... | |
| 24 .sync-select-customization { | 24 .sync-select-customization { |
| 25 margin-top: 10px; | 25 margin-top: 10px; |
| 26 } | 26 } |
| 27 #chooseDataTypesRadio { | 27 #chooseDataTypesRadio { |
| 28 vertical-align: top; | 28 vertical-align: top; |
| 29 } | 29 } |
| 30 #chooseDataTypes > div { | 30 #chooseDataTypes > div { |
| 31 display: inline-block; | 31 display: inline-block; |
| 32 } | 32 } |
| 33 #chooseDataTypesBody { | 33 #chooseDataTypesBody { |
| 34 width: 90%; | |
|
arv (Not doing code reviews)
2010/09/01 01:04:02
This seems like the wrong solution. Maybe you want
| |
| 35 margin-left: 3ex; | |
| 34 } | 36 } |
| 35 #chooseDataTypesBody > div { | 37 #chooseDataTypesBody > div { |
| 36 margin-top: 0px; | 38 margin-top: 0px; |
| 37 -webkit-column-count: 2; | 39 -webkit-column-count: 2; |
| 38 -webkit-column-gap: 10px; | 40 -webkit-column-gap: 10px; |
| 39 column-count: 2; | 41 column-count: 2; |
| 40 column-gap: 10px; | 42 column-gap: 10px; |
| 41 width: 375px; | |
| 42 } | 43 } |
| 43 .sync-item-show { | 44 .sync-item-show { |
| 44 display: block; | 45 display: block; |
| 45 white-space: nowrap; | 46 white-space: nowrap; |
| 46 } | 47 } |
| 48 | |
| 49 .sync-item-show > label { | |
| 50 overflow: hidden; | |
| 51 white-space: nowrap; | |
| 52 text-overflow: ellipsis; | |
| 53 display: inline-block; | |
| 54 width: 92%; | |
|
arv (Not doing code reviews)
2010/09/01 01:04:02
In general percentage widths are not that useful u
| |
| 55 } | |
| 56 | |
| 47 .sync-item-hide { | 57 .sync-item-hide { |
| 48 display: none; | 58 display: none; |
| 49 } | 59 } |
| 50 .sync-label-inactive { | 60 .sync-label-inactive { |
| 51 color: #9B9B9B; | 61 color: #9B9B9B; |
| 52 } | 62 } |
| 53 .sync-label-active { | 63 .sync-label-active { |
| 54 color: #000000; | 64 color: #000000; |
| 55 } | 65 } |
| 56 .sync-data-types { | 66 .sync-data-types { |
| (...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 275 <div class="sync-select-customization"> | 285 <div class="sync-select-customization"> |
| 276 <div class="sync-choice_radio"> | 286 <div class="sync-choice_radio"> |
| 277 <input id="keepEverythingSyncedRadio" type="radio" name="syncChooseDataTypes" | 287 <input id="keepEverythingSyncedRadio" type="radio" name="syncChooseDataTypes" |
| 278 onclick="setDataTypeCheckboxesEnabled(false)"> | 288 onclick="setDataTypeCheckboxesEnabled(false)"> |
| 279 <label for="keepEverythingSyncedRadio" i18n-content="keepeverythingsynced"> | 289 <label for="keepEverythingSyncedRadio" i18n-content="keepeverythingsynced"> |
| 280 </label> | 290 </label> |
| 281 </div> | 291 </div> |
| 282 <div id="chooseDataTypes" class="sync-choice_radio"> | 292 <div id="chooseDataTypes" class="sync-choice_radio"> |
| 283 <input id="chooseDataTypesRadio" type="radio" name="syncChooseDataTypes" | 293 <input id="chooseDataTypesRadio" type="radio" name="syncChooseDataTypes" |
| 284 onclick="setDataTypeCheckboxesEnabled(true)"> | 294 onclick="setDataTypeCheckboxesEnabled(true)"> |
| 295 <label for="chooseDataTypesRadio" i18n-content="choosedatatypes" > | |
| 296 </label> | |
| 285 <div id="chooseDataTypesBody"> | 297 <div id="chooseDataTypesBody"> |
| 286 <label for="chooseDataTypesRadio" i18n-content="choosedatatypes" ></label> | |
| 287 <div> | 298 <div> |
| 288 <!-- Autofill --> | 299 <!-- Autofill --> |
| 289 <div class="sync-item-show" id="autofillItem"> | 300 <div class="sync-item-show" id="autofillItem"> |
|
arv (Not doing code reviews)
2010/09/01 01:04:02
I think there is room for simplification here.
Yo
| |
| 290 <input id="autofillCheckbox" name="dataTypeCheckbox" type="checkbox"> | 301 <input id="autofillCheckbox" name="dataTypeCheckbox" type="checkbox"> |
| 291 <label id="autofillCheckboxLabel" name="dataTypeLabel" | 302 <label id="autofillCheckboxLabel" name="dataTypeLabel" |
| 292 for="autofillCheckbox" i18n-content="autofill" | 303 for="autofillCheckbox" i18n-content="autofill" |
| 293 i18n-values="title:autofill"></label> | 304 i18n-values="title:autofill"></label> |
| 294 </div> | 305 </div> |
| 295 <!-- Bookmarks --> | 306 <!-- Bookmarks --> |
| 296 <div class="sync-item-show" id="bookmarksItem"> | 307 <div class="sync-item-show" id="bookmarksItem"> |
| 297 <input id="bookmarksCheckbox" name="dataTypeCheckbox" type="checkbox"> | 308 <input id="bookmarksCheckbox" name="dataTypeCheckbox" type="checkbox"> |
| 298 <label id="bookmarksCheckboxLabel" name="dataTypeLabel" | 309 <label id="bookmarksCheckboxLabel" name="dataTypeLabel" |
| 299 for="bookmarksCheckbox" i18n-content="bookmarks" | 310 for="bookmarksCheckbox" i18n-content="bookmarks" |
| (...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 347 <span id="throb"></span> | 358 <span id="throb"></span> |
| 348 </span> | 359 </span> |
| 349 <input id="okButton" type="submit" i18n-values="value:ok" /> | 360 <input id="okButton" type="submit" i18n-values="value:ok" /> |
| 350 <input id="cancelButton" type="button" i18n-values="value:cancel" | 361 <input id="cancelButton" type="button" i18n-values="value:cancel" |
| 351 onclick='chrome.send("DialogClose", [""])' /> | 362 onclick='chrome.send("DialogClose", [""])' /> |
| 352 </div> | 363 </div> |
| 353 </div> | 364 </div> |
| 354 </form> | 365 </form> |
| 355 </body> | 366 </body> |
| 356 </html> | 367 </html> |
| OLD | NEW |
