Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4872)

Unified Diff: chrome/browser/sync/resources/choose_datatypes.html

Issue 3244001: Use text-overflow: ellipsis for long words in sync set-up UI. ... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/472/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/resources/choose_datatypes.html
===================================================================
--- chrome/browser/sync/resources/choose_datatypes.html (revision 57631)
+++ chrome/browser/sync/resources/choose_datatypes.html (working copy)
@@ -31,6 +31,8 @@
display: inline-block;
}
#chooseDataTypesBody {
+ width: 90%;
arv (Not doing code reviews) 2010/09/01 01:04:02 This seems like the wrong solution. Maybe you want
+ margin-left: 3ex;
}
#chooseDataTypesBody > div {
margin-top: 0px;
@@ -38,12 +40,20 @@
-webkit-column-gap: 10px;
column-count: 2;
column-gap: 10px;
- width: 375px;
}
.sync-item-show {
display: block;
white-space: nowrap;
}
+
+.sync-item-show > label {
+ overflow: hidden;
+ white-space: nowrap;
+ text-overflow: ellipsis;
+ display: inline-block;
+ width: 92%;
arv (Not doing code reviews) 2010/09/01 01:04:02 In general percentage widths are not that useful u
+}
+
.sync-item-hide {
display: none;
}
@@ -282,8 +292,9 @@
<div id="chooseDataTypes" class="sync-choice_radio">
<input id="chooseDataTypesRadio" type="radio" name="syncChooseDataTypes"
onclick="setDataTypeCheckboxesEnabled(true)">
+ <label for="chooseDataTypesRadio" i18n-content="choosedatatypes" >
+ </label>
<div id="chooseDataTypesBody">
- <label for="chooseDataTypesRadio" i18n-content="choosedatatypes" ></label>
<div>
<!-- Autofill -->
<div class="sync-item-show" id="autofillItem">
arv (Not doing code reviews) 2010/09/01 01:04:02 I think there is room for simplification here. Yo
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698