Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 324006: Merge 29509 - Revert 29457, because this is making ExtensionBrowserTest.PageA... (Closed)

Created:
11 years, 2 months ago by jon
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 29509 - Revert 29457, because this is making ExtensionBrowserTest.PageAction crash on Vista Original description: Implement badges for page actions. Also add badge text color API. Also change color APIs from wanting ARGB to RGBA. BUG=24635 BUG=24644 BUG=25215 Review URL: http://codereview.chromium.org/291003 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/306004 TBR=nsylvain@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -67 lines) Patch
MM chrome/browser/extensions/extension_browser_actions_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/extensions/extension_page_actions_module.cc View 2 chunks +3 lines, -6 lines 0 comments Download
MM chrome/browser/gtk/location_bar_view_gtk.h View 2 chunks +0 lines, -4 lines 0 comments Download
MM chrome/browser/gtk/location_bar_view_gtk.cc View 3 chunks +0 lines, -20 lines 0 comments Download
MM chrome/browser/views/browser_actions_container.cc View 1 chunk +82 lines, -2 lines 0 comments Download
MM chrome/browser/views/location_bar_view.h View 2 chunks +0 lines, -2 lines 0 comments Download
MM chrome/browser/views/location_bar_view.cc View 1 chunk +0 lines, -12 lines 0 comments Download
MM chrome/common/extensions/extension_action.h View 4 chunks +2 lines, -13 lines 0 comments Download
MM chrome/common/extensions/extension_action.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/test/data/extensions/samples/test_browser_action/background.html View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/test/data/extensions/samples/test_page_action/background.html View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jon
11 years, 2 months ago (2009-10-22 21:34:18 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698