Implement badges for page actions. Also add badge text color API.

Implement badges for page actions. Also add badge text color API.

Also change color APIs from wanting ARGB to RGBA.

BUG=24635
BUG=24644
BUG=25215
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29457

[Matt Perry, 2009-10-16 21:22:10]

Evan, can you make sure I did the Linux stuff right? There's not a whole lot
else, so I'm giving you the whole review.

[Evan Stade, 2009-10-16 21:39:37]

mostly lg

http://codereview.chromium.org/291003/diff/1/3
File chrome/browser/gtk/location_bar_view_gtk.cc (right):

http://codereview.chromium.org/291003/diff/1/3#newcode809
Line 809: gfx::Rect bounding_rect(widget->allocation);
does it come out looking right? I should think this bounding rect would be
slightly off. For widgets that have their own gdkwindow, the allocation x, y is
relative to the parent widget; for widgets that don't have their own gdkwindow
the allocation x, y is relative to the gdkwindow they paint on.

Since the event box widget has its own window, its allocation will be relative
to the parent widget, but we want bounding rect to be relative to event->window
== widget->window, so I think you should do bounding_rect.SetOrigin(0, 0) here.

http://codereview.chromium.org/291003/diff/1/5
File chrome/browser/views/browser_actions_container.cc (right):

http://codereview.chromium.org/291003/diff/1/5#newcode301
Line 301: gfx::Rect(width(), height()));
thanks for saving me the effort of firing up my windows box

[Matt Perry, 2009-10-16 21:47:46]

http://codereview.chromium.org/291003/diff/1/3
File chrome/browser/gtk/location_bar_view_gtk.cc (right):

http://codereview.chromium.org/291003/diff/1/3#newcode809
Line 809: gfx::Rect bounding_rect(widget->allocation);
On 2009/10/16 21:39:37, Evan Stade wrote:
> does it come out looking right? I should think this bounding rect would be
> slightly off. For widgets that have their own gdkwindow, the allocation x, y
is
> relative to the parent widget; for widgets that don't have their own gdkwindow
> the allocation x, y is relative to the gdkwindow they paint on.
> 
> Since the event box widget has its own window, its allocation will be relative
> to the parent widget, but we want bounding rect to be relative to
event->window
> == widget->window, so I think you should do bounding_rect.SetOrigin(0, 0)
here.

Thanks for the info. I'm still trying to get it to build on linux (nacl linking
errors). I'll make sure it looks right.