Issue 306004: Revert 29457, because this is making ExtensionBrowserTest.PageAction crash on...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306004: Revert 29457, because this is making ExtensionBrowserTest.PageAction crash on... (Closed)

Created:
11 years, 2 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Revert 29457, because this is making ExtensionBrowserTest.PageAction crash on Vista Original description: Implement badges for page actions. Also add badge text color API. Also change color APIs from wanting ARGB to RGBA. BUG=24635 BUG=24644 BUG=25215 Review URL: http://codereview.chromium.org/291003 TBR=mpcomplete@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29509

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -67 lines)			Patch
M	chrome/browser/extensions/extension_browser_actions_api.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_page_actions_module.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.cc	View	3 chunks	+0 lines, -20 lines	0 comments	Download
M	chrome/browser/views/browser_actions_container.cc	View	1 chunk	+82 lines, -2 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/common/extensions/extension_action.h	View	4 chunks	+2 lines, -13 lines	0 comments	Download
M	chrome/common/extensions/extension_action.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/samples/test_browser_action/background.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/samples/test_page_action/background.html	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)