Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 3186: Refactor the enum RelocMode changing the naming scheme from lower case to... (Closed)

Created:
12 years, 3 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
bak
CC:
v8-dev
Visibility:
Public.

Description

Refactor the enum RelocMode changing the naming scheme from lower case to upper case. Moved it into the RelocInfo class together with the associated is_xxx functions. Renamed is_xxx to IsXxx in the process. Removed the exit_js_frame mode as it was no longer used. Patch Set 2 renames RELOC_MODE_COUNT to NUMBER_OF_MODES and fixes a couple of lint errors. Committed: http://code.google.com/p/v8/source/detail?r=354

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+465 lines, -476 lines) Patch
M src/assembler.h View 1 6 chunks +77 lines, -104 lines 0 comments Download
M src/assembler.cc View 1 9 chunks +50 lines, -53 lines 0 comments Download
M src/assembler-arm.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/assembler-arm.cc View 9 chunks +22 lines, -18 lines 0 comments Download
M src/assembler-arm-inl.h View 4 chunks +13 lines, -13 lines 0 comments Download
M src/assembler-ia32.h View 7 chunks +22 lines, -19 lines 0 comments Download
M src/assembler-ia32.cc View 18 chunks +42 lines, -42 lines 0 comments Download
M src/assembler-ia32-inl.h View 8 chunks +22 lines, -21 lines 0 comments Download
M src/ast.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins-arm.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M src/builtins-ia32.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/codegen-arm.cc View 1 9 chunks +12 lines, -11 lines 0 comments Download
M src/codegen-ia32.cc View 15 chunks +18 lines, -17 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/debug.cc View 14 chunks +18 lines, -24 lines 0 comments Download
M src/disassembler.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M src/ic.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/ic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic-arm.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/macro-assembler-arm.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/macro-assembler-arm.cc View 9 chunks +24 lines, -24 lines 0 comments Download
M src/macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/macro-assembler-ia32.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M src/mark-compact.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/objects.cc View 7 chunks +25 lines, -20 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/rewriter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/spaces.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/stub-cache-arm.cc View 10 chunks +12 lines, -11 lines 0 comments Download
M src/stub-cache-ia32.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-debug.cc View 6 chunks +14 lines, -17 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
12 years, 3 months ago (2008-09-22 12:25:26 UTC) #1
bak
12 years, 3 months ago (2008-09-22 13:55:35 UTC) #2
LGTM,
  Lars

Powered by Google App Engine
This is Rietveld 408576698