Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: src/assembler-ia32.h

Issue 3186: Refactor the enum RelocMode changing the naming scheme from lower case to... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler-arm-inl.h ('k') | src/assembler-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler-ia32.h
===================================================================
--- src/assembler-ia32.h (revision 352)
+++ src/assembler-ia32.h (working copy)
@@ -183,12 +183,14 @@
inline explicit Immediate(Handle<Object> handle);
inline explicit Immediate(Smi* value);
- bool is_zero() const { return x_ == 0 && rmode_ == no_reloc; }
- bool is_int8() const { return -128 <= x_ && x_ < 128 && rmode_ == no_reloc; }
+ bool is_zero() const { return x_ == 0 && rmode_ == RelocInfo::NONE; }
+ bool is_int8() const {
+ return -128 <= x_ && x_ < 128 && rmode_ == RelocInfo::NONE;
+ }
private:
int x_;
- RelocMode rmode_;
+ RelocInfo::Mode rmode_;
friend class Assembler;
};
@@ -211,35 +213,36 @@
INLINE(explicit Operand(Register reg));
// [disp/r]
- INLINE(explicit Operand(int32_t disp, RelocMode rmode));
+ INLINE(explicit Operand(int32_t disp, RelocInfo::Mode rmode));
// disp only must always be relocated
// [base + disp/r]
- explicit Operand(Register base, int32_t disp, RelocMode rmode = no_reloc);
+ explicit Operand(Register base, int32_t disp,
+ RelocInfo::Mode rmode = RelocInfo::NONE);
// [base + index*scale + disp/r]
explicit Operand(Register base,
Register index,
ScaleFactor scale,
int32_t disp,
- RelocMode rmode = no_reloc);
+ RelocInfo::Mode rmode = RelocInfo::NONE);
// [index*scale + disp/r]
explicit Operand(Register index,
ScaleFactor scale,
int32_t disp,
- RelocMode rmode = no_reloc);
+ RelocInfo::Mode rmode = RelocInfo::NONE);
static Operand StaticVariable(const ExternalReference& ext) {
return Operand(reinterpret_cast<int32_t>(ext.address()),
- external_reference);
+ RelocInfo::EXTERNAL_REFERENCE);
}
static Operand StaticArray(Register index,
ScaleFactor scale,
const ExternalReference& arr) {
return Operand(index, scale, reinterpret_cast<int32_t>(arr.address()),
- external_reference);
+ RelocInfo::EXTERNAL_REFERENCE);
}
// Returns true if this Operand is a wrapper for the specified register.
@@ -251,13 +254,13 @@
// The number of bytes in buf_.
unsigned int len_;
// Only valid if len_ > 4.
- RelocMode rmode_;
+ RelocInfo::Mode rmode_;
inline void set_modrm(int mod, // reg == 0
Register rm);
inline void set_sib(ScaleFactor scale, Register index, Register base);
inline void set_disp8(int8_t disp);
- inline void set_dispr(int32_t disp, RelocMode rmode);
+ inline void set_dispr(int32_t disp, RelocInfo::Mode rmode);
inline void set_reg(Register reg) const;
friend class Assembler;
@@ -574,19 +577,19 @@
// Calls
void call(Label* L);
- void call(byte* entry, RelocMode rmode);
+ void call(byte* entry, RelocInfo::Mode rmode);
void call(const Operand& adr);
- void call(Handle<Code> code, RelocMode rmode);
+ void call(Handle<Code> code, RelocInfo::Mode rmode);
// Jumps
void jmp(Label* L); // unconditional jump to L
- void jmp(byte* entry, RelocMode rmode);
+ void jmp(byte* entry, RelocInfo::Mode rmode);
void jmp(const Operand& adr);
- void jmp(Handle<Code> code, RelocMode rmode);
+ void jmp(Handle<Code> code, RelocInfo::Mode rmode);
// Conditional jumps
void j(Condition cc, Label* L, Hint hint = no_hint);
- void j(Condition cc, byte* entry, RelocMode rmode, Hint hint = no_hint);
+ void j(Condition cc, byte* entry, RelocInfo::Mode rmode, Hint hint = no_hint);
void j(Condition cc, Handle<Code> code, Hint hint = no_hint);
// Floating-point operations
@@ -678,7 +681,7 @@
// Writes a single word of data in the code stream.
// Used for inline tables, e.g., jump-tables.
- void dd(uint32_t data, RelocMode reloc_info);
+ void dd(uint32_t data, RelocInfo::Mode reloc_info);
// Writes the absolute address of a bound label at the given position in
// the generated code. That positions should have the relocation mode
@@ -749,7 +752,7 @@
void GrowBuffer();
inline void emit(uint32_t x);
inline void emit(Handle<Object> handle);
- inline void emit(uint32_t x, RelocMode rmode);
+ inline void emit(uint32_t x, RelocInfo::Mode rmode);
inline void emit(const Immediate& x);
// instruction generation
@@ -777,7 +780,7 @@
inline void emit_disp(Label* L, Displacement::Type type);
// record reloc info for current pc_
- void RecordRelocInfo(RelocMode rmode, intptr_t data = 0);
+ void RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data = 0);
friend class CodePatcher;
friend class EnsureSpace;
« no previous file with comments | « src/assembler-arm-inl.h ('k') | src/assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698