Issue 3175037: Add a flag for the showing the Page Info dialog as a bubble. This adds stubs for all platforms.

Issue 3175037: Add a flag for the showing the Page Info dialog as a bubble. This adds stubs for all platforms. (Closed)

Created:
10 years, 4 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
Finnur

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Add a flag for the showing the Page Info dialog as a bubble. This adds stubs for all platforms. BUG=52916 TEST=Compile. Page Info works as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57358

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix Mac; remove braces #

Patch Set 3 : gyp change #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -36 lines)			Patch
M	chrome/browser/cocoa/browser_window_cocoa.mm	View	1	3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/page_info_window_mac.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/cocoa/page_info_window_mac.mm	View	1	5 chunks	+47 lines, -24 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/page_info_window_gtk.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Finnur

http://codereview.chromium.org/3175037/diff/1/2 File chrome/browser/cocoa/browser_window_cocoa.mm (right): http://codereview.chromium.org/3175037/diff/1/2#newcode405 chrome/browser/cocoa/browser_window_cocoa.mm:405: } nit: no braces on single line if & ...

10 years, 4 months ago (2010-08-24 17:39:47 UTC) #2

Finnur

10 years, 4 months ago (2010-08-24 17:40:01 UTC) #3

Forgot. LGTM otherwise. 

On 2010/08/24 17:39:47, Finnur wrote:
> http://codereview.chromium.org/3175037/diff/1/2
> File chrome/browser/cocoa/browser_window_cocoa.mm (right):
> 
> http://codereview.chromium.org/3175037/diff/1/2#newcode405
> chrome/browser/cocoa/browser_window_cocoa.mm:405: }
> nit: no braces on single line if & else clauses.
> 
> http://codereview.chromium.org/3175037/diff/1/5
> File chrome/browser/gtk/browser_window_gtk.cc (right):
> 
> http://codereview.chromium.org/3175037/diff/1/5#newcode1027
> chrome/browser/gtk/browser_window_gtk.cc:1027: }
> Ditto: No need for braces. Your teeth look fine.
> 
> http://codereview.chromium.org/3175037/diff/1/7
> File chrome/browser/views/frame/browser_view.cc (right):
> 
> http://codereview.chromium.org/3175037/diff/1/7#newcode1273
> chrome/browser/views/frame/browser_view.cc:1273: }
> Ditto.

Expand Messages | Collapse Messages