Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: chrome/browser/cocoa/page_info_window_mac.h

Issue 3175037: Add a flag for the showing the Page Info dialog as a bubble. This adds stubs for all platforms. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: gyp change Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/cocoa/page_info_window_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/page_info_window_mac.h
diff --git a/chrome/browser/cocoa/page_info_window_mac.h b/chrome/browser/cocoa/page_info_window_mac.h
index 426475a64bf4d42e28ad236502b7e2ddd04a91a9..587a320aaecc8849011f32e8d077d2d69a30a04f 100644
--- a/chrome/browser/cocoa/page_info_window_mac.h
+++ b/chrome/browser/cocoa/page_info_window_mac.h
@@ -17,9 +17,7 @@ class Profile;
@class PageInfoWindowController;
namespace {
-
class PageInfoWindowMacTest;
-
};
// This bridge is responsible for getting information from the cross-platform
@@ -30,8 +28,10 @@ class PageInfoWindowMac : public PageInfoModel::PageInfoModelObserver {
public:
virtual ~PageInfoWindowMac();
- // Creates and shows the page info.
- static void ShowPageInfo(Profile* profile,
+ // Used to create the page info window; called from the cross-platform
+ // function.
+ static void ShowPageInfo(gfx::NativeWindow parent,
+ Profile* profile,
const GURL& url,
const NavigationEntry::SSLStatus& ssl,
bool show_history);
@@ -47,7 +47,7 @@ class PageInfoWindowMac : public PageInfoModel::PageInfoModelObserver {
private:
friend class ::PageInfoWindowMacTest;
- // Private constructor, called by ShowPageInfo().
+ // Constructor; private. Called by ShowPageInfo().
PageInfoWindowMac(PageInfoWindowController* controller,
Profile* profile,
const GURL& url,
« no previous file with comments | « chrome/browser/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/cocoa/page_info_window_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698