Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: chrome/browser/cocoa/browser_window_cocoa.mm

Issue 3175037: Add a flag for the showing the Page Info dialog as a bubble. This adds stubs for all platforms. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: gyp change Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/cocoa/page_info_window_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/cocoa/browser_window_cocoa.mm b/chrome/browser/cocoa/browser_window_cocoa.mm
index d7c182812d95a473ed877e19fedd5d77361b396b..dfbcda8b503b6f0eff6ed3257f851496ce6da90c 100644
--- a/chrome/browser/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/cocoa/browser_window_cocoa.mm
@@ -5,6 +5,7 @@
#include "chrome/browser/cocoa/browser_window_cocoa.h"
#include "app/l10n_util_mac.h"
+#include "base/command_line.h"
#include "base/logging.h"
#include "base/message_loop.h"
#include "base/sys_string_conversions.h"
@@ -37,6 +38,7 @@
#include "chrome/browser/pref_service.h"
#include "chrome/browser/profile.h"
#include "chrome/browser/tab_contents/tab_contents.h"
+#include "chrome/common/chrome_switches.h"
#include "chrome/common/native_web_keyboard_event.h"
#include "chrome/common/notification_service.h"
#include "chrome/common/pref_names.h"
@@ -395,7 +397,11 @@ void BrowserWindowCocoa::ShowPageInfo(Profile* profile,
const GURL& url,
const NavigationEntry::SSLStatus& ssl,
bool show_history) {
- PageInfoWindowMac::ShowPageInfo(profile, url, ssl, show_history);
+ const CommandLine* command_line(CommandLine::ForCurrentProcess());
+ if (command_line->HasSwitch(switches::kEnableNewPageInfoBubble))
+ browser::ShowPageInfoBubble(window(), profile, url, ssl, show_history);
+ else
+ browser::ShowPageInfo(window(), profile, url, ssl, show_history);
}
void BrowserWindowCocoa::ShowAppMenu() {
« no previous file with comments | « no previous file | chrome/browser/cocoa/page_info_window_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698