Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 3171031: Add mixed content warning to the Page Info bubble.... (Closed)

Created:
10 years, 4 months ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
Jay Civelli, ian fette
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Add mixed content warning to the Page Info bubble. BUG=http://crbug.com/52916 TEST=Navigate to a page with mixed http and https content. The gray padlock should appear in the Omnibox icon and in the infobubble when you click it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57654

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -31 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/page_info_window_mac_unittest.mm View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/page_info_model.h View 1 2 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/page_info_model.cc View 1 11 chunks +23 lines, -16 lines 0 comments Download
M chrome/browser/views/page_info_bubble_view.cc View 1 3 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/views/page_info_window_view.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Finnur
10 years, 4 months ago (2010-08-26 22:29:42 UTC) #1
Finnur
Ian, can you also take a quick look, especially as this relates to page_info_model.cc The ...
10 years, 4 months ago (2010-08-26 23:26:06 UTC) #2
Jay Civelli
LGTM
10 years, 4 months ago (2010-08-26 23:29:58 UTC) #3
Finnur
10 years, 3 months ago (2010-08-27 09:27:58 UTC) #4
Thanks. I'll check this in now.

Ian, I'll address any comments you may have in a follow-up cl.

Powered by Google App Engine
This is Rietveld 408576698