Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: chrome/browser/page_info_model.h

Issue 3171031: Add mixed content warning to the Page Info bubble.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/page_info_window_mac_unittest.mm ('k') | chrome/browser/page_info_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_info_model.h
===================================================================
--- chrome/browser/page_info_model.h (revision 57521)
+++ chrome/browser/page_info_model.h (working copy)
@@ -35,8 +35,16 @@
SECTION_INFO_FIRST_VISIT,
};
+ enum SectionInfoState {
+ SECTION_STATE_OK = 0,
+ // If state is OK but contains mixed content.
+ SECTION_STATE_WARNING,
+ // For example, unverified identity over HTTPS.
+ SECTION_STATE_ERROR,
+ };
+
struct SectionInfo {
- SectionInfo(bool state,
+ SectionInfo(SectionInfoState state,
const string16& title,
const string16& headline,
const string16& description,
@@ -48,8 +56,8 @@
type(type) {
}
- bool state; // True if state is OK, false otherwise (ex of bad states:
- // unverified identity over HTTPS).
+ // The overall state of the connection (error, warning, ok).
+ SectionInfoState state;
// The title of the section.
string16 title;
« no previous file with comments | « chrome/browser/cocoa/page_info_window_mac_unittest.mm ('k') | chrome/browser/page_info_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698