Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2188)

Unified Diff: chrome/browser/cocoa/page_info_window_mac_unittest.mm

Issue 3171031: Add mixed content warning to the Page Info bubble.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/page_info_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/page_info_window_mac_unittest.mm
===================================================================
--- chrome/browser/cocoa/page_info_window_mac_unittest.mm (revision 57510)
+++ chrome/browser/cocoa/page_info_window_mac_unittest.mm (working copy)
@@ -19,7 +19,7 @@
class FakeModel : public PageInfoModel {
public:
- void AddSection(bool state,
+ void AddSection(SectionInfoState state,
const string16& title,
const string16& description,
SectionInfoType type) {
@@ -111,13 +111,13 @@
TEST_F(PageInfoWindowMacTest, NoHistoryNoSecurity) {
- model_->AddSection(false,
+ model_->AddSection(PageInfoModel::SECTION_STATE_ERROR,
l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_IDENTITY_TITLE),
l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_UNKNOWN_PARTY,
ASCIIToUTF16("google.com")),
PageInfoModel::SECTION_INFO_IDENTITY);
- model_->AddSection(false,
+ model_->AddSection(PageInfoModel::SECTION_STATE_ERROR,
l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_CONNECTION_TITLE),
l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_NOT_ENCRYPTED_CONNECTION_TEXT,
@@ -131,13 +131,13 @@
TEST_F(PageInfoWindowMacTest, HistoryNoSecurity) {
- model_->AddSection(false,
+ model_->AddSection(PageInfoModel::SECTION_STATE_ERROR,
l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_IDENTITY_TITLE),
l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_UNKNOWN_PARTY,
ASCIIToUTF16("google.com")),
PageInfoModel::SECTION_INFO_IDENTITY);
- model_->AddSection(false,
+ model_->AddSection(PageInfoModel::SECTION_STATE_ERROR,
l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_CONNECTION_TITLE),
l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_NOT_ENCRYPTED_CONNECTION_TEXT,
@@ -148,7 +148,7 @@
// asynchronously, so replicate the double-build here.
bridge_->ModelChanged();
- model_->AddSection(false,
+ model_->AddSection(PageInfoModel::SECTION_STATE_ERROR,
l10n_util::GetStringUTF16(
IDS_PAGE_INFO_SECURITY_TAB_PERSONAL_HISTORY_TITLE),
l10n_util::GetStringUTF16(
@@ -162,7 +162,7 @@
TEST_F(PageInfoWindowMacTest, NoHistoryMixedSecurity) {
- model_->AddSection(true,
+ model_->AddSection(PageInfoModel::SECTION_STATE_OK,
l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_IDENTITY_TITLE),
l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY,
@@ -173,7 +173,7 @@
// region (kImageSize).
string16 title =
l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_CONNECTION_TITLE);
- model_->AddSection(true,
+ model_->AddSection(PageInfoModel::SECTION_STATE_OK,
title,
l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_SENTENCE_LINK,
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/page_info_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698