Issue 3170043: Revert 57311 - Part 2 of the SSL InfoBubble....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3170043: Revert 57311 - Part 2 of the SSL InfoBubble.... (Closed)

Created:
10 years, 4 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Finnur

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 57311 - Part 2 of the SSL InfoBubble. - Added Certificate Information link. - Changed iconography to be: Identity : Green check mark vs. Red skull and bones Connection: Green padlock vs. Orange exclamation point. (This used to be Green checkmark and Orange Exclamation point for both sections. - Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before. BUG=52916 TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show. Review URL: http://codereview.chromium.org/3136031 TBR=finnur@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57314

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -103 lines)			Patch
M	chrome/app/theme/pageinfo_bad.png	View	Binary file		0 comments	Download
M	chrome/app/theme/pageinfo_good.png	View	Binary file		0 comments	Download
M	chrome/browser/page_info_model.h	View	3 chunks	+6 lines, -18 lines	0 comments	Download
M	chrome/browser/page_info_model.cc	View	5 chunks	+6 lines, -11 lines	0 comments	Download
M	chrome/browser/views/page_info_bubble_view.h	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/views/page_info_bubble_view.cc	View	10 chunks	+29 lines, -66 lines	0 comments	Download
M	chrome/browser/views/page_info_window_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages