Part 2 of the SSL InfoBubble....

Part 2 of the SSL InfoBubble.

- Added Certificate Information link.

- Changed iconography to be:
  Identity  : Green check mark vs. Red skull and bones
  Connection: Green padlock vs. Orange exclamation point.
  (This used to be Green checkmark and Orange Exclamation point for both sections.

- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.

BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57311

[Jay Civelli, 2010-08-24 16:26:56]

LGTM

http://codereview.chromium.org/3136031/diff/9001/10005
File chrome/browser/views/page_info_bubble_view.cc (right):

http://codereview.chromium.org/3136031/diff/9001/10005#newcode42
chrome/browser/views/page_info_bubble_view.cc:42: explicit
Section(PageInfoBubbleView* owner,
Remove explicit.

[Finnur, 2010-08-24 17:15:51]

I made the suggestion and changed the pngs. I was under the impression we wanted
separate sets of good/bad state pngs, whereas the UI leads want to consolidate.

Can you take a quick look at page_info_bubble_view.cc and the two pngs?

 On 2010/08/24 16:26:56, Jay Civelli wrote:
> LGTM
> 
> http://codereview.chromium.org/3136031/diff/9001/10005
> File chrome/browser/views/page_info_bubble_view.cc (right):
> 
> http://codereview.chromium.org/3136031/diff/9001/10005#newcode42
> chrome/browser/views/page_info_bubble_view.cc:42: explicit
> Section(PageInfoBubbleView* owner,
> Remove explicit.

[Jay Civelli, 2010-08-24 17:25:39]

LGTM