Change the FileUtilProxy callbacks to report error codes instead of booleans....

Change the FileUtilProxy callbacks to report error codes instead of booleans.

BUG=none
TEST=none



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57228

[darin (slow to review), 2010-08-24 17:43:14]

LGTM

http://codereview.chromium.org/3165050/diff/5001/6001
File base/file_util_proxy.cc (right):

http://codereview.chromium.org/3165050/diff/5001/6001#newcode42
base/file_util_proxy.cc:42: int ErrorCode() {
nit: consider naming these set_error_code() and error_code().  also, the getter
should be 'const'

http://codereview.chromium.org/3165050/diff/5001/6003
File base/platform_file.h (right):

http://codereview.chromium.org/3165050/diff/5001/6003#newcode41
base/platform_file.h:41: PLATFORM_FILE_TRUNCATE = 4096  // Used on Windows only
don't we need to support truncation on other platforms?

[dumi, 2010-08-24 19:14:57]

http://codereview.chromium.org/3165050/diff/5001/6001
File base/file_util_proxy.cc (right):

http://codereview.chromium.org/3165050/diff/5001/6001#newcode42
base/file_util_proxy.cc:42: int ErrorCode() {
On 2010/08/24 17:43:14, darin wrote:
> nit: consider naming these set_error_code() and error_code().  also, the
getter
> should be 'const'

done. when do we use methods_like_this() and MethodsLikeThis()? i'm asking
because all other functions are LikeThis().

http://codereview.chromium.org/3165050/diff/5001/6003
File base/platform_file.h (right):

http://codereview.chromium.org/3165050/diff/5001/6003#newcode41
base/platform_file.h:41: PLATFORM_FILE_TRUNCATE = 4096  // Used on Windows only
On 2010/08/24 17:43:14, darin wrote:
> don't we need to support truncation on other platforms?

this belongs to a different CL. removed.

[darin (slow to review), 2010-08-25 04:58:50]

On Tue, Aug 24, 2010 at 12:14 PM, <dumi@chromium.org> wrote:

>
> http://codereview.chromium.org/3165050/diff/5001/6001
> File base/file_util_proxy.cc (right):
>
> http://codereview.chromium.org/3165050/diff/5001/6001#newcode42
> base/file_util_proxy.cc:42: int ErrorCode() {
> On 2010/08/24 17:43:14, darin wrote:
>
>> nit: consider naming these set_error_code() and error_code().  also,
>>
> the getter
>
>> should be 'const'
>>
>
> done. when do we use methods_like_this() and MethodsLikeThis()? i'm
> asking because all other functions are LikeThis().
>
>
simple getters and setters that are equivalent to direct member variable
access
are good to name using unix_hacker style.  that way it is clear at the
callsites
that the method is super cheap to call.  if you see a unix_hacker() method
within
the body of a for loop, you can know that there is no cost to the function.
 if you
are in the debugger and you encounter such a function, you know that there
is no
need to step into it, etc.  it's therefore a readability thing to use
unix_hacker() style.

it is also OK to use exclusively MixedCaps.  For example, you might not want
people to make assumptions about how fast your methods are to call (even if
today
they are implemented as simple member variable accesses).



>
> http://codereview.chromium.org/3165050/diff/5001/6003
> File base/platform_file.h (right):
>
> http://codereview.chromium.org/3165050/diff/5001/6003#newcode41
> base/platform_file.h:41: PLATFORM_FILE_TRUNCATE = 4096  // Used on
> Windows only
> On 2010/08/24 17:43:14, darin wrote:
>
>> don't we need to support truncation on other platforms?
>>
>
> this belongs to a different CL. removed.
>
>
Ah, OK

-Darin

>
> http://codereview.chromium.org/3165050/show
>