Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3154)

Unified Diff: base/file_util_proxy.h

Issue 3165050: Change the FileUtilProxy callbacks to report error codes instead of booleans.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/file_util_proxy.cc » ('j') | base/file_util_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_util_proxy.h
===================================================================
--- base/file_util_proxy.h (revision 56938)
+++ base/file_util_proxy.h (working copy)
@@ -17,40 +17,40 @@
// This class provides asynchronous access to common file routines.
class FileUtilProxy {
public:
- // This callback is used by methods that report success with a bool. It is
+ // This callback is used by methods that report only an error code. It is
// valid to pass NULL as the callback parameter to any function that takes a
// StatusCallback, in which case the operation will complete silently.
- typedef Callback1<bool /* succeeded */>::Type StatusCallback;
+ typedef Callback1<int /* error code */>::Type StatusCallback;
// Creates or opens a file with the given flags. It is invalid to pass NULL
// for the callback.
- typedef Callback2<base::PassPlatformFile, bool /* created */>::Type
- CreateOrOpenCallback;
- static void CreateOrOpen(scoped_refptr<MessageLoopProxy> message_loop_proxy,
+ typedef Callback3<int /* error code */, base::PassPlatformFile,
+ bool /* created */>::Type CreateOrOpenCallback;
+ static bool CreateOrOpen(scoped_refptr<MessageLoopProxy> message_loop_proxy,
const FilePath& file_path,
int file_flags,
CreateOrOpenCallback* callback);
// Creates a temporary file for writing. The path and an open file handle
// are returned. It is invalid to pass NULL for the callback.
- typedef Callback2<base::PassPlatformFile, FilePath>::Type
- CreateTemporaryCallback;
- static void CreateTemporary(
+ typedef Callback3<int /* error code */, base::PassPlatformFile,
+ FilePath>::Type CreateTemporaryCallback;
+ static bool CreateTemporary(
scoped_refptr<MessageLoopProxy> message_loop_proxy,
CreateTemporaryCallback* callback);
// Close the given file handle.
- static void Close(scoped_refptr<MessageLoopProxy> message_loop_proxy,
+ static bool Close(scoped_refptr<MessageLoopProxy> message_loop_proxy,
base::PlatformFile,
StatusCallback* callback);
// Deletes a file or empty directory.
- static void Delete(scoped_refptr<MessageLoopProxy> message_loop_proxy,
+ static bool Delete(scoped_refptr<MessageLoopProxy> message_loop_proxy,
const FilePath& file_path,
StatusCallback* callback);
// Deletes a directory and all of its contents.
- static void RecursiveDelete(
+ static bool RecursiveDelete(
scoped_refptr<MessageLoopProxy> message_loop_proxy,
const FilePath& file_path,
StatusCallback* callback);
« no previous file with comments | « no previous file | base/file_util_proxy.cc » ('j') | base/file_util_proxy.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698