Change the FileUtilProxy callbacks to report error codes instead of booleans....

base/platform_file.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_PLATFORM_FILE_H_
 #define BASE_PLATFORM_FILE_H_
 #pragma once
 
 #include "build/build_config.h"
 #if defined(OS_WIN)
@@ skipping 19 matching lines @@
   PLATFORM_FILE_CREATE = 2,
   PLATFORM_FILE_OPEN_ALWAYS = 4,    // May create a new file.
   PLATFORM_FILE_CREATE_ALWAYS = 8,  // May overwrite an old file.
   PLATFORM_FILE_READ = 16,
   PLATFORM_FILE_WRITE = 32,
   PLATFORM_FILE_EXCLUSIVE_READ = 64,  // EXCLUSIVE is opposite of Windows SHARE
   PLATFORM_FILE_EXCLUSIVE_WRITE = 128,
   PLATFORM_FILE_ASYNC = 256,
   PLATFORM_FILE_TEMPORARY = 512,        // Used on Windows only
   PLATFORM_FILE_HIDDEN = 1024,          // Used on Windows only
-  PLATFORM_FILE_DELETE_ON_CLOSE = 2048
+  PLATFORM_FILE_DELETE_ON_CLOSE = 2048,
+  PLATFORM_FILE_TRUNCATE = 4096  // Used on Windows only

[darin (slow to review), 2010/08/24 17:43:14]

don't we need to support truncation on other platforms?

[dumi, 2010/08/24 19:14:57]

this belongs to a different CL. removed.

+};
+
+// TODO(dumi): add more specific error codes for CreatePlatformFile().
+// TODO(dumi): add more error codes as we add new methods to FileUtilProxy.
+enum PlatformFileErrors {
+  PLATFORM_FILE_OK = 0,
+  PLATFORM_FILE_ERROR = -1
 };
 
 // Creates or opens the given file. If PLATFORM_FILE_OPEN_ALWAYS is used, and
 // |created| is provided, |created| will be set to true if the file was created
 // or to false in case the file was just opened.
 PlatformFile CreatePlatformFile(const FilePath& name,
                                 int flags,
                                 bool* created);
 // Deprecated.
 PlatformFile CreatePlatformFile(const std::wstring& name,
@@ skipping 37 matching lines @@
     return temp;
   }
 
  private:
   PlatformFile* value_;
 };
 
 }  // namespace base
 
 #endif  // BASE_PLATFORM_FILE_H_