Changed mft_h264_decoder's API to match with video_decode_engine.h. Also chan...

Changed mft_h264_decoder's API to match with video_decode_engine.h. Also changed the example and unittests.

Implementation of mft_h264_decoder.cc is similar to ffmpeg_video_decode_engine.cc. For now, a d3d surface output from the decoder is converted from NV12 to YV12 and stored in regular memory. So rendering with --enable-dxva is a bit
slower for now. Once we figure out how to connect with ANGLE, we won't need the conversion / transfer.

basic_renderer.* is now replaced with a simpler implementation of EventHandler inside the example code. d3d_util.* is also removed because d3d9 initialization is now moved inside the initialization of the decoder and it is the only place where it is used.

BUG=none
TEST=included in this patch


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57261

[imcheng, 2010-08-23 20:58:34]

Please review. Sorry for changing a lot of things. Thanks.

[Alpha Left Google, 2010-08-24 23:03:33]

LGTM with a few questions.

http://codereview.chromium.org/3156046/diff/1/2
File media/filters/video_decode_engine.h (right):

http://codereview.chromium.org/3156046/diff/1/2#newcode75
media/filters/video_decode_engine.h:75: virtual ~EventHandler() {}
good catch.

http://codereview.chromium.org/3156046/diff/1/8
File media/mf/mft_h264_decoder.cc (right):

http://codereview.chromium.org/3156046/diff/1/8#newcode21
media/mf/mft_h264_decoder.cc:21: #pragma comment(lib, "delayimp")
What is this new lib for?

http://codereview.chromium.org/3156046/diff/1/8#newcode26
media/mf/mft_h264_decoder.cc:26: #pragma comment(lib, "strmiids.lib")
What is this new lib for?

[imcheng, 2010-08-24 23:40:50]

http://codereview.chromium.org/3156046/diff/1/8
File media/mf/mft_h264_decoder.cc (right):

http://codereview.chromium.org/3156046/diff/1/8#newcode21
media/mf/mft_h264_decoder.cc:21: #pragma comment(lib, "delayimp")
On 2010/08/24 23:03:33, Alpha wrote:
> What is this new lib for?
> 

Not sure why it was there. Removed it.

http://codereview.chromium.org/3156046/diff/1/8#newcode26
media/mf/mft_h264_decoder.cc:26: #pragma comment(lib, "strmiids.lib")
On 2010/08/24 23:03:33, Alpha wrote:
> What is this new lib for?
> 

Needed for MR_BUFFER_SERVICE (getting d3d surface from imfmediabuffer)

[hclam, 2010-08-25 04:39:53]

According to MSDN this lib is for data flow in the graph:
http://msdn.microsoft.com/en-us/library/dd390170(VS.85).aspx

Can the decoder run without this lib? It's always better to have less
dependency.

Alpha

2010年8月24日16:40 <imcheng@chromium.org>:

>
> http://codereview.chromium.org/3156046/diff/1/8
> File media/mf/mft_h264_decoder.cc (right):
>
> http://codereview.chromium.org/3156046/diff/1/8#newcode21
> media/mf/mft_h264_decoder.cc:21: #pragma comment(lib, "delayimp")
> On 2010/08/24 23:03:33, Alpha wrote:
>
>> What is this new lib for?
>>
>
>
> Not sure why it was there. Removed it.
>
>
> http://codereview.chromium.org/3156046/diff/1/8#newcode26
> media/mf/mft_h264_decoder.cc:26: #pragma comment(lib, "strmiids.lib")
> On 2010/08/24 23:03:33, Alpha wrote:
>
>> What is this new lib for?
>>
>
>
> Needed for MR_BUFFER_SERVICE (getting d3d surface from imfmediabuffer)
>
>
> http://codereview.chromium.org/3156046/show
>

[imcheng, 2010-08-25 17:15:55]

I did some investigation and it seems that it is possible to not have
strmiids.lib, but only if evr.h (where MR_BUFFER_SERVICE is defined) comes after
mfapi.h (where MF_BUFFER_SERVICE is declared). Odd. I will make a separate patch
to remove the lib.