Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3152034: Remove wstrings in bookmarks, part 5. (Closed)

Created:
10 years, 4 months ago by viettrungluu
Modified:
9 years, 6 months ago
CC:
chromium-reviews, ncarter (slow), Raghu Simha, ben+cc_chromium.org, John Grabowski, Paweł Hajdan Jr., idana, pam+watch_chromium.org, brettw-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Remove wstrings in bookmarks, part 5. Remove wstring BookmarkModel::AddURL(). BUG=23581 TEST=builds and passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56860

Patch Set 1 #

Patch Set 2 : fix 80-col problem #

Patch Set 3 : gtk + mac fixes #

Patch Set 4 : more fixes #

Patch Set 5 : yet moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -78 lines) Patch
M chrome/browser/bookmarks/bookmark_codec_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_index_unittest.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/cocoa/applescript/bookmark_folder_applescript.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/bookmark_all_tabs_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_all_tabs_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_folder_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_button_cell_unittest.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/bookmark_button_unittest.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/bookmark_editor_controller.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_menu_cocoa_controller_unittest.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/bookmark_model_observer_for_cocoa_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/gtk/bookmark_utils_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/bookmark_model_verifier.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc View 9 chunks +19 lines, -19 lines 0 comments Download
M chrome/test/model_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
10 years, 4 months ago (2010-08-20 13:50:30 UTC) #1
Miranda Callahan
10 years, 4 months ago (2010-08-20 15:14:03 UTC) #2 
On 2010/08/20 13:50:30, viettrungluu wrote:
> 

L
G
T
MMMMMMM

Powered by Google App Engine
This is Rietveld 408576698