Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3666)

Unified Diff: chrome/browser/sync/profile_sync_service_unittest.cc

Issue 3152034: Remove wstrings in bookmarks, part 5. (Closed)
Patch Set: yet moar Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_unittest.cc b/chrome/browser/sync/profile_sync_service_unittest.cc
index 4afd8746f5f6e0e55816c4a6bd39b82eb44ad079..1a6a6462c5d73393c161fe4bb3b195be8bf84a77 100644
--- a/chrome/browser/sync/profile_sync_service_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_unittest.cc
@@ -547,10 +547,11 @@ TEST_F(ProfileSyncServiceTest, ServerChangeProcessing) {
adds.AddURL(L"Some old site", "http://slog.thestranger.com/",
bookmark_bar_id(), u1);
// u5 tests an empty-string title.
- std::string javascript_url("javascript:(function(){var w=window.open(" \
- "'about:blank','gnotesWin','location=0,menubar=0," \
- "scrollbars=0,status=0,toolbar=0,width=300," \
- "height=300,resizable');});");
+ std::string javascript_url(
+ "javascript:(function(){var w=window.open(" \
+ "'about:blank','gnotesWin','location=0,menubar=0," \
+ "scrollbars=0,status=0,toolbar=0,width=300," \
+ "height=300,resizable');});");
adds.AddURL(L"", javascript_url, other_bookmarks_id(), 0);
vector<sync_api::SyncManager::ChangeRecord>::const_iterator it;
@@ -1272,7 +1273,8 @@ TEST_F(ProfileSyncServiceTestWithData, ModelAssociationInvalidPersistence) {
// the situation where bookmark model is different from sync model and
// make sure model associator correctly rebuilds associations.
const BookmarkNode* bookmark_bar_node = model_->GetBookmarkBarNode();
- model_->AddURL(bookmark_bar_node, 0, L"xtra", GURL("http://www.xtra.com"));
+ model_->AddURL(bookmark_bar_node, 0, ASCIIToUTF16("xtra"),
+ GURL("http://www.xtra.com"));
// Now restart the sync service. This time it will try to use the persistent
// associations and realize that they are invalid and hence will rebuild
// associations.
« no previous file with comments | « chrome/browser/history/history_backend_unittest.cc ('k') | chrome/browser/views/bookmark_bar_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698