Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm

Issue 3152034: Remove wstrings in bookmarks, part 5. (Closed)
Patch Set: yet moar Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #include "base/scoped_nsobject.h" 7 #include "base/scoped_nsobject.h"
8 #include "base/sys_string_conversions.h" 8 #include "base/sys_string_conversions.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/browser/bookmarks/bookmark_model.h" 10 #include "chrome/browser/bookmarks/bookmark_model.h"
11 #import "chrome/browser/cocoa/bookmark_all_tabs_controller.h" 11 #import "chrome/browser/cocoa/bookmark_all_tabs_controller.h"
12 #include "chrome/browser/cocoa/browser_test_helper.h" 12 #include "chrome/browser/cocoa/browser_test_helper.h"
13 #import "chrome/browser/cocoa/cocoa_test_helper.h" 13 #import "chrome/browser/cocoa/cocoa_test_helper.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 #include "testing/platform_test.h" 15 #include "testing/platform_test.h"
16 16
17 @interface BookmarkAllTabsControllerOverride : BookmarkAllTabsController 17 @interface BookmarkAllTabsControllerOverride : BookmarkAllTabsController
18 @end 18 @end
19 19
20 @implementation BookmarkAllTabsControllerOverride 20 @implementation BookmarkAllTabsControllerOverride
21 21
22 - (void)UpdateActiveTabPairs { 22 - (void)UpdateActiveTabPairs {
23 ActiveTabsNameURLPairVector* activeTabPairsVector = 23 ActiveTabsNameURLPairVector* activeTabPairsVector =
24 [self activeTabPairsVector]; 24 [self activeTabPairsVector];
25 activeTabPairsVector->clear(); 25 activeTabPairsVector->clear();
26 activeTabPairsVector->push_back( 26 activeTabPairsVector->push_back(
27 ActiveTabNameURLPair(L"at-0", GURL("http://at-0.com"))); 27 ActiveTabNameURLPair(ASCIIToUTF16("at-0"), GURL("http://at-0.com")));
28 activeTabPairsVector->push_back( 28 activeTabPairsVector->push_back(
29 ActiveTabNameURLPair(L"at-1", GURL("http://at-1.com"))); 29 ActiveTabNameURLPair(ASCIIToUTF16("at-1"), GURL("http://at-1.com")));
30 activeTabPairsVector->push_back( 30 activeTabPairsVector->push_back(
31 ActiveTabNameURLPair(L"at-2", GURL("http://at-2.com"))); 31 ActiveTabNameURLPair(ASCIIToUTF16("at-2"), GURL("http://at-2.com")));
32 } 32 }
33 33
34 @end 34 @end
35 35
36 class BookmarkAllTabsControllerTest : public CocoaTest { 36 class BookmarkAllTabsControllerTest : public CocoaTest {
37 public: 37 public:
38 BrowserTestHelper helper_; 38 BrowserTestHelper helper_;
39 const BookmarkNode* parent_node_; 39 const BookmarkNode* parent_node_;
40 BookmarkAllTabsControllerOverride* controller_; 40 BookmarkAllTabsControllerOverride* controller_;
41 const BookmarkNode* group_a_; 41 const BookmarkNode* group_a_;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 // OK button should always be enabled. 73 // OK button should always be enabled.
74 EXPECT_TRUE([controller_ okButtonEnabled]); 74 EXPECT_TRUE([controller_ okButtonEnabled]);
75 [controller_ selectTestNodeInBrowser:group_a_]; 75 [controller_ selectTestNodeInBrowser:group_a_];
76 [controller_ setDisplayName:@"ALL MY TABS"]; 76 [controller_ setDisplayName:@"ALL MY TABS"];
77 [controller_ ok:nil]; 77 [controller_ ok:nil];
78 EXPECT_EQ(4, group_a_->GetChildCount()); 78 EXPECT_EQ(4, group_a_->GetChildCount());
79 const BookmarkNode* folderChild = group_a_->GetChild(3); 79 const BookmarkNode* folderChild = group_a_->GetChild(3);
80 EXPECT_EQ(folderChild->GetTitleAsString16(), ASCIIToUTF16("ALL MY TABS")); 80 EXPECT_EQ(folderChild->GetTitleAsString16(), ASCIIToUTF16("ALL MY TABS"));
81 EXPECT_EQ(3, folderChild->GetChildCount()); 81 EXPECT_EQ(3, folderChild->GetChildCount());
82 } 82 }
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/bookmark_all_tabs_controller.mm ('k') | chrome/browser/cocoa/bookmark_bar_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698