Issue 3116011: Revert 56059 - Merge 55103 - Refactored extension privilege enumeration and i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3116011: Revert 56059 - Merge 55103 - Refactored extension privilege enumeration and i... (Closed)

Created:
10 years, 4 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman, tony

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/472/src/

Visibility:
Public.

Description

Revert 56059 - Merge 55103 - Refactored extension privilege enumeration and implemented URLPattern comparisons. This will allow checks on per origin extension resource access. Added origin check when loading extension resources. BUG=45876 TEST=ExtensionTest.IsPrivilegeIncrease TEST=ExtensionTest.EffectiveHostPermissions TEST=ExtensionBrowserTest.OriginPrivileges Review URL: http://codereview.chromium.org/2808051 TBR=cdn@chromium.org Review URL: http://codereview.chromium.org/3173018 TBR=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56067

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -151 lines)			Patch
M	chrome/browser/extensions/extension_browsertests_misc.cc	View	3 chunks	+0 lines, -28 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.cc	View	2 chunks	+9 lines, -11 lines	0 comments	Download
M	chrome/browser/extensions/extension_protocols.cc	View	1 chunk	+4 lines, -16 lines	0 comments	Download
M	chrome/browser/net/chrome_url_request_context.h	View	3 chunks	+4 lines, -13 lines	0 comments	Download
M	chrome/browser/net/chrome_url_request_context.cc	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/extension.cc	View	2 chunks	+13 lines, -14 lines	0 comments	Download
M	chrome/common/extensions/extension_unittest.cc	View	2 chunks	+28 lines, -30 lines	0 comments	Download
M	chrome/common/extensions/url_pattern.h	View	2 chunks	+0 lines, -16 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/extension/manifest.json	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/extension/test.png	View	Binary file		0 comments	Download
D	chrome/test/data/extensions/origin_privileges/index.html	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

10 years, 4 months ago (2010-08-16 21:31:13 UTC) #2

ExtensionBrowserTest.OriginPrivileges is currently failing on the official
builders.  Is this expected?

Expand Messages | Collapse Messages