Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 3173018: Merge 55103 - Refactored extension privilege enumeration and implemented URLP... (Closed)

Created:
10 years, 4 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
Cris Neckar
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Merge 55103 - Refactored extension privilege enumeration and implemented URLPattern comparisons. This will allow checks on per origin extension resource access. Added origin check when loading extension resources. BUG=45876 TEST=ExtensionTest.IsPrivilegeIncrease TEST=ExtensionTest.EffectiveHostPermissions TEST=ExtensionBrowserTest.OriginPrivileges Review URL: http://codereview.chromium.org/2808051 TBR=cdn@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -63 lines) Patch
M chrome/browser/extensions/extension_browsertests_misc.cc View 3 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 3 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 2 chunks +14 lines, -13 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 3 chunks +34 lines, -32 lines 0 comments Download
M chrome/common/extensions/url_pattern.h View 2 chunks +16 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/origin_privileges/extension/manifest.json View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/origin_privileges/extension/test.png View Binary file 0 comments Download
A chrome/test/data/extensions/origin_privileges/index.html View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Aaron Boodman
10 years, 4 months ago (2010-08-13 18:54:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698