Refactored extension privilege enumeration and implemented URLPattern compari...

Refactored extension privilege enumeration and implemented URLPattern comparisons. 
This will allow checks on per origin extension resource access. Added origin
check when loading extension resources. 

BUG=45876
TEST=ExtensionTest.IsPrivilegeIncrease 
TEST=ExtensionTest.EffectiveHostPermissions
TEST=ExtensionBrowserTest.OriginPrivileges


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55103

[Aaron Boodman, 2010-08-02 21:31:11]

A test would also be good. Take a look at the api tests in
chrome/test/data/extensions/api_tests.

http://codereview.chromium.org/2808051/diff/1/3
File chrome/browser/extensions/extension_protocols.cc (right):

http://codereview.chromium.org/2808051/diff/1/3#newcode83
chrome/browser/extensions/extension_protocols.cc:83: if
(info->frame_origin().empty() &&
Shouldn't this be !info->frame_origin().empty() ?

http://codereview.chromium.org/2808051/diff/1/5
File chrome/browser/net/chrome_url_request_context.h (right):

http://codereview.chromium.org/2808051/diff/1/5#newcode86
chrome/browser/net/chrome_url_request_context.h:86: ExtensionExtent
GetHostPermissionsForExtension(const std::string& id);
Even though it is a crazy long name, I'd prefer the "Effective" adjective here
for consistency.

http://codereview.chromium.org/2808051/diff/1/10
File chrome/common/extensions/url_pattern.h (right):

http://codereview.chromium.org/2808051/diff/1/10#newcode173
chrome/common/extensions/url_pattern.h:173: return a.host_.compare(b.host_) < 0;
To keep the terminology consistent, I'd prefer this was called
EffectiveHostCompare, same with below.

http://codereview.chromium.org/2808051/diff/1/10#newcode176
chrome/common/extensions/url_pattern.h:176: // Used for origin comparisons in a
std::set
Nit: comments end with a period.

[Cris Neckar, 2010-08-04 19:34:50]

http://codereview.chromium.org/2808051/diff/1/3
File chrome/browser/extensions/extension_protocols.cc (right):

http://codereview.chromium.org/2808051/diff/1/3#newcode83
chrome/browser/extensions/extension_protocols.cc:83: if
(info->frame_origin().empty() &&
On 2010/08/02 21:31:11, Aaron Boodman wrote:
> Shouldn't this be !info->frame_origin().empty() ?

Done.

http://codereview.chromium.org/2808051/diff/1/5
File chrome/browser/net/chrome_url_request_context.h (right):

http://codereview.chromium.org/2808051/diff/1/5#newcode86
chrome/browser/net/chrome_url_request_context.h:86: ExtensionExtent
GetHostPermissionsForExtension(const std::string& id);
On 2010/08/02 21:31:11, Aaron Boodman wrote:
> Even though it is a crazy long name, I'd prefer the "Effective" adjective here
> for consistency.

Done.

http://codereview.chromium.org/2808051/diff/1/10
File chrome/common/extensions/url_pattern.h (right):

http://codereview.chromium.org/2808051/diff/1/10#newcode173
chrome/common/extensions/url_pattern.h:173: return a.host_.compare(b.host_) < 0;
On 2010/08/02 21:31:11, Aaron Boodman wrote:
> To keep the terminology consistent, I'd prefer this was called
> EffectiveHostCompare, same with below.

Done.

http://codereview.chromium.org/2808051/diff/1/10#newcode176
chrome/common/extensions/url_pattern.h:176: // Used for origin comparisons in a
std::set
On 2010/08/02 21:31:11, Aaron Boodman wrote:
> Nit: comments end with a period.

Done.

[Aaron Boodman, 2010-08-04 20:32:04]

Please unpack the crx and use LoadExtension() instead of InstallExtension(). The
packed crx files are hard to maintain.

[Cris Neckar, 2010-08-04 21:28:06]

On 2010/08/04 20:32:04, Aaron Boodman wrote:
> Please unpack the crx and use LoadExtension() instead of InstallExtension().
The
> packed crx files are hard to maintain.

Done.

[Aaron Boodman, 2010-08-04 22:52:24]

LGTM w/ one last change below. Thanks for your patience. You can just submit
with the change without waiting for me to review.

http://codereview.chromium.org/2808051/diff/39001/17013
File chrome/test/data/extensions/origin_privileges.html (right):

http://codereview.chromium.org/2808051/diff/39001/17013#newcode1
chrome/test/data/extensions/origin_privileges.html:1: <title>Unmodified</title>
You should move this into origin_privileges folder just for code organization
purposes.