Issue 3091005: Rename GetStringAsUTF16() to GetString() (and overload), etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3091005: Rename GetStringAsUTF16() to GetString() (and overload), etc. (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Visibility:
Public.

Description

Rename GetStringAsUTF16() to GetString() (and overload), etc. Also do some drive-by wstring/wchar_t -> string/char changes (in addition to the necessary ones). BUG=none TEST=builds and tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54944

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+147 lines, -168 lines)			Patch
M	base/values.h	View	5 chunks	+7 lines, -12 lines	0 comments	Download
M	base/values.cc	View	7 chunks	+8 lines, -24 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	3 chunks	+10 lines, -9 lines	0 comments	Download
M	chrome/browser/background_contents_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_codec.h	View	1 chunk	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_codec.cc	View	2 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/dom_ui/net_internals_ui.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_history_api.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_history_api_constants.h	View	1 chunk	+19 lines, -19 lines	0 comments	Download
M	chrome/browser/extensions/extension_history_api_constants.cc	View	1 chunk	+19 lines, -19 lines	0 comments	Download
M	chrome/browser/extensions/extension_omnibox_api.cc	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/geolocation/access_token_store.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/geolocation/network_location_provider_unittest.cc	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/geolocation/network_location_request.cc	View	10 chunks	+36 lines, -36 lines	0 comments	Download
M	chrome/browser/plugin_updater.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages