chrome/browser/extensions/extension_history_api.cc - Issue 3091005: Rename GetStringAsUTF16() to GetString() (and overload), etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_history_api.cc

Issue 3091005: Rename GetStringAsUTF16() to GetString() (and overload), etc. (Closed)

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_history_api.cc

diff --git a/chrome/browser/extensions/extension_history_api.cc b/chrome/browser/extensions/extension_history_api.cc

index 6261a4bf36cd3e02d32844be3d35ac0898aefcbe..95d3acb4e3dd58e9029821047684fcd8e87acbb4 100644

--- a/chrome/browser/extensions/extension_history_api.cc

+++ b/chrome/browser/extensions/extension_history_api.cc

@@ -248,8 +248,7 @@ bool SearchHistoryFunction::RunAsyncImpl() {

// Initialize the HistoryQuery

string16 search_text;

- EXTENSION_FUNCTION_VALIDATE(json->GetStringAsUTF16(keys::kTextKey,

- &search_text));

+ EXTENSION_FUNCTION_VALIDATE(json->GetString(keys::kTextKey, &search_text));

history::QueryOptions options;

options.SetRecentDayRange(1);