Issue 3086006: Merge 54410 - [Mac] Un-tweak omnibox height and spacing and font....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3086006: Merge 54410 - [Mac] Un-tweak omnibox height and spacing and font.... (Closed)

Created:
10 years, 4 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/472/src/

Visibility:
Public.

Merge 54410 - [Mac] Un-tweak omnibox height and spacing and font. Partial revert of http://codereview.chromium.org/3046029 . Toolbar.xib change to make Omnibox 27px tall again. Omnibox font back to system size, shift baselines to match, inset location icon additional pixel to look good WRT text spacing, adjust ev and keyword bubbles to match, adjust popup to match. BUG=50765, 50575 TEST=See 50765 Review URL: http://codereview.chromium.org/2806098 TBR=shess@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54687

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -10 lines)			Patch
M	chrome/app/nibs/Toolbar.xib	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup_view_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/bubble_decoration.mm	View	3 chunks	+1 line, -5 lines	0 comments	Download

Total messages: 1 (0 generated)