Issue 2806098: [Mac] Un-tweak omnibox height and spacing and font.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2806098: [Mac] Un-tweak omnibox height and spacing and font. (Closed)

Created:
10 years, 4 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

[Mac] Un-tweak omnibox height and spacing and font. Partial revert of http://codereview.chromium.org/3046029 . Toolbar.xib change to make Omnibox 27px tall again. Omnibox font back to system size, shift baselines to match, inset location icon additional pixel to look good WRT text spacing, adjust ev and keyword bubbles to match, adjust popup to match. BUG=50765, 50575 TEST=See 50765 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54410

Patch Set 1 #

Patch Set 2 : Peter suggested bumping RHS spacing. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
M	chrome/app/nibs/Toolbar.xib	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup_view_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/bubble_decoration.mm	View		3 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

Since you're in MTV... The popup text seems to align right without an offset change ...

10 years, 4 months ago (2010-07-30 22:10:30 UTC) #1

Peter Kasting

The rightmost item (i.e. the star) is supposed to come in 1 px too, I ...

10 years, 4 months ago (2010-07-30 22:13:00 UTC) #2

Scott Hess - ex-Googler

10 years, 4 months ago (2010-07-30 23:44:13 UTC) #3

On 2010/07/30 22:13:00, Peter Kasting wrote:
> The rightmost item (i.e. the star) is supposed to come in 1 px too, I don't
see
> that change here.
> 
> LGTM otherwise.

OK.  Got the RHS, too.  Didn't combine the constants because the tree is open
now and that would make me feel I needed another try cycle...

Expand Messages | Collapse Messages