[Mac] First pass at final sizing of toolbar items.

[Mac] First pass at final sizing of toolbar items.

Toolbar.xib changes:
 - buttons from 31x27 to 29x29 so that the visual is 27x27.
 - shift things left to take up opened space.
 - omnibox to 29 pixels tall.
 - wrench also to 29x29.
 - all of that raised a single pixel to recenter.
 - swap positions of home and reload.

Modify home-button-adjustment code to reflect rearranged
home/reload positions.

Increase Omnibox font size by one point to match increased field
height (and Windows Omnibox).  Revise various font clients to
recognize this.  Shift Omnibox baseline and other measurements to
account for increased height.

Shift globe/search icon in by one pixel so icons on both sides of
Omnibox are 4px from border.  Matching shift in popup.

Fix EV-bubble to use appropriate green for text, rather than black.

Push out bubble to have a single-pixel space WRT Omnibox border.
Tighten corners to tuck into Omnibox corners.  Handle different
lhs padding versus location icon (image should end up in same
spot, even though the bubble draws outside the image).

BUG=50575
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54188

[Scott Hess - ex-Googler, 2010-07-28 22:46:16]

There is more to be done, especially around browser actions.  After this, I have
a number of in-omnibox things to do, but they should be completely independent
of general-toolbar stuff.

[Bons, 2010-07-29 01:04:27]

LGTM

http://codereview.chromium.org/3046029/diff/1/7
File chrome/browser/cocoa/location_bar/bubble_decoration.mm (right):

http://codereview.chromium.org/3046029/diff/1/7#newcode20
chrome/browser/cocoa/location_bar/bubble_decoration.mm:20: // handles things. 
Here, it just draws the bubble edge a little bit
s/handles/handle ?

[Scott Hess - ex-Googler, 2010-07-29 18:05:34]

Sigh.  Tree is open and I forgot to send a try job.

http://codereview.chromium.org/3046029/diff/1/7
File chrome/browser/cocoa/location_bar/bubble_decoration.mm (right):

http://codereview.chromium.org/3046029/diff/1/7#newcode20
chrome/browser/cocoa/location_bar/bubble_decoration.mm:20: // handles things. 
Here, it just draws the bubble edge a little bit
On 2010/07/29 01:04:27, Andrew Bonventre (Bons) wrote:
> s/handles/handle ?

In this case, "views" was a noun, not a plural of "view", so I reworded to "the
views implementation handles".

[Bons, 2010-07-29 18:08:23]

LGTM

Thanks for the re-wording.

On Thu, Jul 29, 2010 at 2:05 PM,  <shess@chromium.org> wrote:
> Sigh.  Tree is open and I forgot to send a try job.
>
>
> http://codereview.chromium.org/3046029/diff/1/7
> File chrome/browser/cocoa/location_bar/bubble_decoration.mm (right):
>
> http://codereview.chromium.org/3046029/diff/1/7#newcode20
> chrome/browser/cocoa/location_bar/bubble_decoration.mm:20: // handles
> things.  Here, it just draws the bubble edge a little bit
> On 2010/07/29 01:04:27, Andrew Bonventre (Bons) wrote:
>>
>> s/handles/handle ?
>
> In this case, "views" was a noun, not a plural of "view", so I reworded
> to "the views implementation handles".
>
> http://codereview.chromium.org/3046029/show
>

[Scott Hess - ex-Googler, 2010-07-29 20:23:47]

Thx.

I need to upgrade to 10.6 so that running unit tests locally isn't so painful. 
I'm going to blatantly go ahead and check in with my stupid unit-test changes,
once the trybot agrees.  And it will.

-scott


On 2010/07/29 18:08:23, Andrew Bonventre (Bons) wrote:
> LGTM
> 
> Thanks for the re-wording.
> 
> On Thu, Jul 29, 2010 at 2:05 PM,  <mailto:shess@chromium.org> wrote:
> > Sigh. &nbsp;Tree is open and I forgot to send a try job.
> >
> >
> > http://codereview.chromium.org/3046029/diff/1/7
> > File chrome/browser/cocoa/location_bar/bubble_decoration.mm (right):
> >
> > http://codereview.chromium.org/3046029/diff/1/7#newcode20
> > chrome/browser/cocoa/location_bar/bubble_decoration.mm:20: // handles
> > things. &nbsp;Here, it just draws the bubble edge a little bit
> > On 2010/07/29 01:04:27, Andrew Bonventre (Bons) wrote:
> >>
> >> s/handles/handle ?
> >
> > In this case, "views" was a noun, not a plural of "view", so I reworded
> > to "the views implementation handles".
> >
> > http://codereview.chromium.org/3046029/show
> >
>

[Robert Sesek, 2010-07-30 14:37:21]

http://codereview.chromium.org/3046029/diff/9001/10001
File chrome/app/nibs/Toolbar.xib (right):

http://codereview.chromium.org/3046029/diff/9001/10001#newcode5
chrome/app/nibs/Toolbar.xib:5: <string
key="IBDocument.SystemVersion">9L31a</string>
Please only save XIBs on 10.6.