Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 308001: Chromium fix for "Copy Image".... (Closed)

Created:
11 years, 2 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Chromium fix for "Copy Image". (WebCore fix is http://codereview.chromium.org/294023 .) BUG=http://crbug.com/13099 TEST="Copy Image" works; see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29812

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -8 lines) Patch
M DEPS View 5 1 chunk +1 line, -1 line 0 comments Download
M app/clipboard/clipboard.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M app/clipboard/clipboard_mac.mm View 1 2 3 4 5 2 chunks +43 lines, -0 lines 0 comments Download
M webkit/api/src/ChromiumBridge.cpp View 1 2 3 4 5 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Avi (use Gerrit)
Darin: The chromium bridge replumbing. Pink: The Mac fun CC Nico: Because this is a ...
11 years, 2 months ago (2009-10-20 16:08:17 UTC) #1
darin (slow to review)
http://codereview.chromium.org/308001/diff/1/4 File webkit/api/src/ChromiumBridge.cpp (right): http://codereview.chromium.org/308001/diff/1/4#newcode126 Line 126: WebImage(*image), sourceURL, title); nit: please rework this so ...
11 years, 2 months ago (2009-10-20 16:15:40 UTC) #2
Nico
Some wild speculation: http://codereview.chromium.org/308001/diff/1/3 File app/clipboard/clipboard_mac.mm (right): http://codereview.chromium.org/308001/diff/1/3#newcode129 Line 129: CFDataCreate(kCFAllocatorDefault, The docs say that ...
11 years, 2 months ago (2009-10-20 16:29:08 UTC) #3
Avi (use Gerrit)
On 2009/10/20 16:29:08, Nico wrote: > Some wild speculation: Was paranoid about references to the ...
11 years, 2 months ago (2009-10-20 16:32:01 UTC) #4
pink (ping after 24hrs)
http://codereview.chromium.org/308001/diff/1/3 File app/clipboard/clipboard_mac.mm (right): http://codereview.chromium.org/308001/diff/1/3#newcode137 Line 137: CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB)); should we be using mac_util::GetSystemColorSpace() instead? http://codereview.chromium.org/308001/diff/1/3#newcode159 ...
11 years, 2 months ago (2009-10-20 16:38:33 UTC) #5
Avi (use Gerrit)
On 2009/10/20 16:29:08, Nico wrote: > CGBitmapContextCreateImage() might not copy the data according to > ...
11 years, 2 months ago (2009-10-20 16:40:02 UTC) #6
Nico
LG. As pink said, make sure that colors match if you open a color picker ...
11 years, 2 months ago (2009-10-20 16:49:55 UTC) #7
Avi (use Gerrit)
On 2009/10/20 16:49:55, Nico wrote: > As pink said, make sure that colors match I'm ...
11 years, 2 months ago (2009-10-20 16:53:11 UTC) #8
darin (slow to review)
On Tue, Oct 20, 2009 at 9:53 AM, <avi@chromium.org> wrote: > On 2009/10/20 16:49:55, Nico ...
11 years, 2 months ago (2009-10-20 17:03:00 UTC) #9
Avi (use Gerrit)
On 2009/10/20 17:03:00, darin wrote: > We just need to fix the renderer and associated ...
11 years, 2 months ago (2009-10-20 17:57:05 UTC) #10
Avi (use Gerrit)
Darin— I have a general idea of how to send a CGImage over IPC but ...
11 years, 2 months ago (2009-10-20 18:28:14 UTC) #11
darin (slow to review)
I'm fine deferring it. -Darin On Tue, Oct 20, 2009 at 11:28 AM, <avi@chromium.org> wrote: ...
11 years, 2 months ago (2009-10-20 18:35:24 UTC) #12
Avi (use Gerrit)
On 2009/10/20 18:35:24, darin wrote: > I'm fine deferring it. http://crbug.com/25322 then.
11 years, 2 months ago (2009-10-20 18:40:04 UTC) #13
Nico
If you go to e.g. wikipedia.org, mark all the page, hit cmd-c, and then paste ...
11 years, 2 months ago (2009-10-20 18:55:45 UTC) #14
Avi (use Gerrit)
11 years, 2 months ago (2009-10-20 19:02:56 UTC) #15
On 2009/10/20 18:55:45, Nico wrote:
> If you [...] mark all the page, hit cmd-c, and
> then paste in textedit, it looks like it keeps the correct colors.
> Which code path does this take?

That copies HTML. The <img> tag is copied, and TextEdit uses some variation of
NSAttributedString's initWithHTML: methods, which call down to WebKit.

> Can't we do something similar for
> copying a single image?

No. If you want an image on the clipboard you have to put an image on the
clipboard, not the URL of an image.

Powered by Google App Engine
This is Rietveld 408576698