Issue 3023037: Remove Value/StringValue's ...UTF16() methods in favour of overloading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3023037: Remove Value/StringValue's ...UTF16() methods in favour of overloading. (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, jam, ben+cc_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Remove Value/StringValue's ...UTF16() methods in favour of overloading. Still to do: do the same for DictionaryValue. BUG=none TEST=builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54751

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -86 lines)			Patch
M	base/values.h	View	1	3 chunks	+16 lines, -10 lines	0 comments	Download
M	base/values.cc	View		8 chunks	+31 lines, -21 lines	0 comments	Download
M	base/values_unittest.cc	View		9 chunks	+49 lines, -44 lines	0 comments	Download
M	chrome/browser/configuration_policy_pref_store.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/configuration_policy_provider_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/history2_ui.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/dom_ui/history_ui.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/geolocation/access_token_store.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugin_updater.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM