Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5627)

Unified Diff: chrome/browser/configuration_policy_pref_store.cc

Issue 3023037: Remove Value/StringValue's ...UTF16() methods in favour of overloading. (Closed)
Patch Set: I'm an idiot. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/values_unittest.cc ('k') | chrome/browser/configuration_policy_provider_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/configuration_policy_pref_store.cc
diff --git a/chrome/browser/configuration_policy_pref_store.cc b/chrome/browser/configuration_policy_pref_store.cc
index 94b0fad3007afab97ca788506cd2ec70f52a5985..a59fc25af075fa48cb88db049e8001890cc646f6 100644
--- a/chrome/browser/configuration_policy_pref_store.cc
+++ b/chrome/browser/configuration_policy_pref_store.cc
@@ -286,7 +286,7 @@ bool ConfigurationPolicyPrefStore::ApplyPluginPolicy(PolicyType policy,
Value* value) {
if (policy == kPolicyDisabledPlugins) {
string16 plugin_list;
- if (value->GetAsUTF16(&plugin_list)) {
+ if (value->GetAsString(&plugin_list)) {
std::vector<string16> plugin_names;
// Change commas into tabs so that we can change escaped
// tabs back into commas, leaving non-escaped commas as tabs
@@ -303,7 +303,7 @@ bool ConfigurationPolicyPrefStore::ApplyPluginPolicy(PolicyType policy,
for (std::vector<string16>::const_iterator i(plugin_names.begin());
i != plugin_names.end(); ++i) {
if (!i->empty()) {
- list->Append(Value::CreateStringValueFromUTF16(*i));
+ list->Append(Value::CreateStringValue(*i));
added_plugin = true;
}
}
« no previous file with comments | « base/values_unittest.cc ('k') | chrome/browser/configuration_policy_provider_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698