Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Unified Diff: chrome/browser/dom_ui/history_ui.cc

Issue 3023037: Remove Value/StringValue's ...UTF16() methods in favour of overloading. (Closed)
Patch Set: I'm an idiot. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/history2_ui.cc ('k') | chrome/browser/geolocation/access_token_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/history_ui.cc
diff --git a/chrome/browser/dom_ui/history_ui.cc b/chrome/browser/dom_ui/history_ui.cc
index fc4fd63b1f6c4f03c5a38d5e42ec6574724b3f96..4cf5bf3bbafe9b4a64de3ba4b18c4196a20c1e43 100644
--- a/chrome/browser/dom_ui/history_ui.cc
+++ b/chrome/browser/dom_ui/history_ui.cc
@@ -222,7 +222,7 @@ void BrowsingHistoryHandler::HandleRemoveURLsOnOneDay(const Value* value) {
continue;
const StringValue* string_value = static_cast<const StringValue*>(*v);
string16 string16_value;
- if (!string_value->GetAsUTF16(&string16_value))
+ if (!string_value->GetAsString(&string16_value))
continue;
urls.insert(GURL(string16_value));
}
@@ -311,7 +311,7 @@ void BrowsingHistoryHandler::ExtractSearchHistoryArguments(const Value* value,
list_member->GetType() == Value::TYPE_STRING) {
const StringValue* string_value =
static_cast<const StringValue*>(list_member);
- string_value->GetAsUTF16(query);
+ string_value->GetAsString(query);
}
// Get search month.
@@ -320,7 +320,7 @@ void BrowsingHistoryHandler::ExtractSearchHistoryArguments(const Value* value,
const StringValue* string_value =
static_cast<const StringValue*>(list_member);
string16 string16_value;
- string_value->GetAsUTF16(&string16_value);
+ string_value->GetAsString(&string16_value);
base::StringToInt(string16_value, month);
}
}
« no previous file with comments | « chrome/browser/dom_ui/history2_ui.cc ('k') | chrome/browser/geolocation/access_token_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698