Issue 3020038: Revert 53892 - Initial scriptable object implementation....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3020038: Revert 53892 - Initial scriptable object implementation.... (Closed)

Created:
10 years, 4 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
bryeung, awong

CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, dmac, awong, garykac, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 53892 - Initial scriptable object implementation. Broke ChromiumOS ARM build, reverting. Errors from log: remoting/client/plugin/chromoting_scriptable_object.cc: In member function 'virtual bool remoting::ChromotingScriptableObject::HasProperty(const pp::Var&, pp::Var*)': remoting/client/plugin/chromoting_scriptable_object.cc:48: error: NULL used in arithmetic remoting/client/plugin/chromoting_scriptable_object.cc: In member function 'virtual bool remoting::ChromotingScriptableObject::HasMethod(const pp::Var&, pp::Var*)': remoting/client/plugin/chromoting_scriptable_object.cc:63: error: NULL used in arithmetic BUG=50248 TEST=write javascript to manually setup connection. Review URL: http://codereview.chromium.org/3064009 TBR=ajwong@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53949

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -329 lines)			Patch
M	remoting/client/client_util.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	remoting/client/client_util.cc	View	1 chunk	+38 lines, -0 lines	0 comments	Download
M	remoting/client/client_util_unittest.cc	View	1 chunk	+16 lines, -1 line	0 comments	Download
M	remoting/client/plugin/chromoting_plugin.h	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	remoting/client/plugin/chromoting_plugin.cc	View	4 chunks	+38 lines, -39 lines	0 comments	Download
D	remoting/client/plugin/chromoting_scriptable_object.h	View	1 chunk	+0 lines, -100 lines	0 comments	Download
D	remoting/client/plugin/chromoting_scriptable_object.cc	View	1 chunk	+0 lines, -172 lines	0 comments	Download
M	remoting/client/plugin/pepper_view.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	remoting/client/x11_view.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	remoting/remoting.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages