Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 3064009: Initial scriptable object implementation. (Closed)

Created:
10 years, 5 months ago by awong
Modified:
9 years, 7 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, dmac, awong, garykac, Paweł Hajdan Jr.
Visibility:
Public.

Description

Initial scriptable object implementation. BUG=50248 TEST=write javascript to manually setup connection. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53892

Patch Set 1 #

Patch Set 2 : make the connect() call invokable via javascript. #

Total comments: 2

Patch Set 3 : Fixes x11 client and the pepper view. #

Patch Set 4 : Fix alpha's style nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -107 lines) Patch
M remoting/client/client_util.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/client/client_util.cc View 1 1 chunk +0 lines, -38 lines 0 comments Download
M remoting/client/client_util_unittest.cc View 1 1 chunk +1 line, -16 lines 0 comments Download
M remoting/client/plugin/chromoting_plugin.h View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M remoting/client/plugin/chromoting_plugin.cc View 1 2 4 chunks +39 lines, -38 lines 0 comments Download
A remoting/client/plugin/chromoting_scriptable_object.h View 1 2 3 1 chunk +100 lines, -0 lines 0 comments Download
A remoting/client/plugin/chromoting_scriptable_object.cc View 1 1 chunk +172 lines, -0 lines 0 comments Download
M remoting/client/plugin/pepper_view.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M remoting/client/x11_view.cc View 2 chunks +3 lines, -1 line 0 comments Download
M remoting/remoting.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
awong
This one's fun...
10 years, 4 months ago (2010-07-27 22:51:43 UTC) #1
Alpha Left Google
some style nits, LGTM otherwise. http://codereview.chromium.org/3064009/diff/2001/3007 File remoting/client/plugin/chromoting_scriptable_object.h (right): http://codereview.chromium.org/3064009/diff/2001/3007#newcode29 remoting/client/plugin/chromoting_scriptable_object.h:29: #ifndef REMOTING_CLIENT_PLUGIN_CHROMOTING_SCRIPTABLE_OBJECT_H ifdefs are ...
10 years, 4 months ago (2010-07-28 00:44:45 UTC) #2
Alpha Left Google
10 years, 4 months ago (2010-07-28 01:08:59 UTC) #3
awsome. LGTM again.

Powered by Google App Engine
This is Rietveld 408576698