Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: remoting/client/plugin/chromoting_plugin.cc

Issue 3020038: Revert 53892 - Initial scriptable object implementation.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/plugin/chromoting_plugin.h ('k') | remoting/client/plugin/chromoting_scriptable_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/plugin/chromoting_plugin.cc
===================================================================
--- remoting/client/plugin/chromoting_plugin.cc (revision 53948)
+++ remoting/client/plugin/chromoting_plugin.cc (working copy)
@@ -15,13 +15,12 @@
#include "remoting/client/chromoting_client.h"
#include "remoting/client/host_connection.h"
#include "remoting/client/jingle_host_connection.h"
-#include "remoting/client/plugin/chromoting_scriptable_object.h"
#include "remoting/client/plugin/pepper_input_handler.h"
#include "remoting/client/plugin/pepper_view.h"
#include "remoting/jingle_glue/jingle_thread.h"
#include "third_party/ppapi/c/pp_event.h"
+#include "third_party/ppapi/c/pp_rect.h"
#include "third_party/ppapi/cpp/completion_callback.h"
-#include "third_party/ppapi/cpp/rect.h"
namespace remoting {
@@ -41,7 +40,9 @@
// to the message loop before this point. Right now, we don't have a well
// defined stop for the plugin process, and the thread shutdown is likely a
// race condition.
- context_.Stop();
+ if (context_.get()) {
+ context_->Stop();
+ }
}
bool ChromotingPlugin::Init(uint32_t argc,
@@ -62,48 +63,60 @@
pepper_main_loop_dont_post_to_me_ = MessageLoop::current();
LOG(INFO) << "Started ChromotingPlugin::Init";
- // Start all the threads.
- context_.Start();
+ // Extract the URL from the arguments.
+ const char* url = NULL;
+ for (uint32_t i = 0; i < argc; ++i) {
+ if (strcmp(argn[i], "src") == 0) {
+ url = argv[i];
+ break;
+ }
+ }
+ if (!url) {
+ return false;
+ }
+
+ ClientConfig config;
+ if (!GetLoginInfoFromUrlParams(url, &config)) {
+ LOG(WARNING) << "Could not parse URL: " << url;
+ return false;
+ }
+
// Create the chromoting objects.
- host_connection_.reset(new JingleHostConnection(&context_));
+ host_connection_.reset(new JingleHostConnection(context_.get()));
view_.reset(new PepperView(this));
input_handler_.reset(new PepperInputHandler());
-
- // Default to a medium grey.
- view_->SetSolidFill(0xFFCDCDCD);
-
- return true;
-}
-
-void ChromotingPlugin::Connect(const ClientConfig& config) {
- DCHECK(CurrentlyOnPluginThread());
-
client_.reset(new ChromotingClient(config,
- &context_,
+ context_.get(),
host_connection_.get(),
view_.get(),
input_handler_.get(),
NULL));
+ // Default to a medium grey.
+ view_->SetSolidFill(0xFFCDCDCD);
+
// Kick off the connection.
+ context_->Start();
client_->Start();
+
+ return true;
}
-void ChromotingPlugin::ViewChanged(const pp::Rect& position,
- const pp::Rect& clip) {
+void ChromotingPlugin::ViewChanged(const PP_Rect& position,
+ const PP_Rect& clip) {
DCHECK(CurrentlyOnPluginThread());
// TODO(ajwong): This is going to be a race condition when the view changes
// and we're in the middle of a Paint().
LOG(INFO) << "ViewChanged "
- << position.x() << ","
- << position.y() << ","
- << position.width() << ","
- << position.height();
+ << position.point.x << ","
+ << position.point.y << ","
+ << position.size.width << ","
+ << position.size.height;
- view_->SetViewport(position.x(), position.y(),
- position.width(), position.height());
+ view_->SetViewport(position.point.x, position.point.y,
+ position.size.width, position.size.height);
view_->Paint();
}
@@ -134,18 +147,4 @@
return false;
}
-pp::Var ChromotingPlugin::GetInstanceObject() {
- LOG(ERROR) << "Getting instance object.";
- if (instance_object_.is_void()) {
- ChromotingScriptableObject* object = new ChromotingScriptableObject(this);
- object->Init();
-
- LOG(ERROR) << "Object initted.";
- // The pp::Var takes ownership of object here.
- instance_object_ = pp::Var(object);
- }
-
- return instance_object_;
-}
-
} // namespace remoting
« no previous file with comments | « remoting/client/plugin/chromoting_plugin.h ('k') | remoting/client/plugin/chromoting_scriptable_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698